Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert the notification to use notiffany gem #106

Merged
merged 10 commits into from
Oct 10, 2015

Commits on Oct 2, 2015

  1. Refactor and simplify integration tests

    * add DRY gitdocs execution into #gitdocs_command and name the wrapper
      methods consistently
    * remove some unnecessary calls to abs_current_dir when asserting
      output
    * make the pid_file and gitdocs binary paths absolute so they are not
      affect by the setting of the current directory
    * consolidate the #before_setup and #after_teardown methods
    * replace #git_clone_and_gitdocs_add with #gitdocs_create, which
      eliminates some extra code and more more through the gitdocs CLI
      which makes the integration test more consistent
    acant committed Oct 2, 2015
    Configuration menu
    Copy the full SHA
    988c3cd View commit details
    Browse the repository at this point in the history

Commits on Oct 10, 2015

  1. Extract git factory and assertions from unit

    DRY the duplicate from the units tests for fabricating and making
    assertions about git repositories.
    acant committed Oct 10, 2015
    Configuration menu
    Copy the full SHA
    f396cd9 View commit details
    Browse the repository at this point in the history
  2. Update integrations tests to use GitFactory

    Add GitFactory.append in the process.
    Remove methods from the integration/test_helper which are no longer
    used.
    acant committed Oct 10, 2015
    Configuration menu
    Copy the full SHA
    18ee742 View commit details
    Browse the repository at this point in the history
  3. Add a more useful Arbua failure display

    I think that will be useful, particularly for finding errors in Travis.
    On a test failure the log file and the current aruba directory will be
    printed.
    acant committed Oct 10, 2015
    Configuration menu
    Copy the full SHA
    88cb09f View commit details
    Browse the repository at this point in the history
  4. Add --verbose to the start command

    The verbose flag will increase the log level to DEBUG, which will also
    additional debugging logs to be added to the code, but hidden during
    normal operations.
    acant committed Oct 10, 2015
    Configuration menu
    Copy the full SHA
    3785d99 View commit details
    Browse the repository at this point in the history
  5. Change --debug to --foreground

    Now that the --verbose flag exists to increase log level, I think that
    this is a more accurate name for this flag.
    acant committed Oct 10, 2015
    Configuration menu
    Copy the full SHA
    6f28c5d View commit details
    Browse the repository at this point in the history
  6. Clean up the existing logging

    Add logging methods to Gitdocs to reduce method chains, and update the
    existing log calls to best specify appropriate log levels.
    acant committed Oct 10, 2015
    Configuration menu
    Copy the full SHA
    c2cacc2 View commit details
    Browse the repository at this point in the history
  7. Log the notification messages

    ...the notifications will be logged even if the notifications
    themselves are not being displayed.
    acant committed Oct 10, 2015
    Configuration menu
    Copy the full SHA
    91db314 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    0361b1c View commit details
    Browse the repository at this point in the history
  9. Set git user info during arbua tests

    Because the HOME directory is reset for these tests git would not use
    an existing global configuration. Write the user.name and user.email
    into the testing home directory, so valid value will be present when
    committing during the integration tests.
    acant committed Oct 10, 2015
    Configuration menu
    Copy the full SHA
    68677e0 View commit details
    Browse the repository at this point in the history