Convert the notification to use notiffany gem #106
Conversation
|
What happened with the tests? https://travis-ci.org/nesquena/gitdocs/builds/79777537 are they just broken in general? |
|
Frustratingly, no. If you have time, could you pull this branch and run the tests? It would give me another data point, and might help clarify if this is really specific to the TravisCI environment. |
|
I am uploading some temporary commits to try and gather more information about the failures on TravisCI. They will be removed before merging. |
|
Ok thanks for the heads up, sorry travis is giving you so much trouble. |
|
np. Hopefully by the time I'm finish, I'll have a better understanding of...something. :) |
acant
force-pushed
the
feature/notification
branch
from
6aca9ce
to
3858774
Compare
* add DRY gitdocs execution into #gitdocs_command and name the wrapper methods consistently * remove some unnecessary calls to abs_current_dir when asserting output * make the pid_file and gitdocs binary paths absolute so they are not affect by the setting of the current directory * consolidate the #before_setup and #after_teardown methods * replace #git_clone_and_gitdocs_add with #gitdocs_create, which eliminates some extra code and more more through the gitdocs CLI which makes the integration test more consistent
acant
force-pushed
the
feature/notification
branch
from
1d1d7a8
to
1f51270
Compare
DRY the duplicate from the units tests for fabricating and making assertions about git repositories.
Add GitFactory.append in the process. Remove methods from the integration/test_helper which are no longer used.
I think that will be useful, particularly for finding errors in Travis. On a test failure the log file and the current aruba directory will be printed.
The verbose flag will increase the log level to DEBUG, which will also additional debugging logs to be added to the code, but hidden during normal operations.
Now that the --verbose flag exists to increase log level, I think that this is a more accurate name for this flag.
Add logging methods to Gitdocs to reduce method chains, and update the existing log calls to best specify appropriate log levels.
...the notifications will be logged even if the notifications themselves are not being displayed.
Because the HOME directory is reset for these tests git would not use an existing global configuration. Write the user.name and user.email into the testing home directory, so valid value will be present when committing during the integration tests.
acant
force-pushed
the
feature/notification
branch
from
3b01d63
to
68677e0
Compare
|
And the test are passing! The problem was that git was not finding a user.email and user.name setting when running the integration tests in TravisCI. My wonder if the TravisCI image used to have those values set in the system config, and now it does not. @nesquena I have re-based the existing commits so they are ready to merge if you like. And I'll continue with the notification changes here or in another PR. |
|
Sweet! Great news. |
Convert the notification to use notiffany gem
|
Thanks @nesquena. I just updated the README and CHANGELOG in master, so everything should be up to date now. |
|
Nice! |
Also going to do some refactoring and clean up in the process. Specifically I hope that I will make the integration tests faster and more reliable.