Add optional plist serialization format to Rabl #153
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Awesome work @alzeih . Once we can get some test cases in, I will merge this and release a version. |
|
@alzeih Would love to add this in too. Any chance you'd have a chance to look at test cases akin to https://github.com/nesquena/rabl/blob/master/test/msgpack_engine_test.rb ? |
|
Added the test cases. If you like, I will close this request and squash the two commits here and rebase on the current master - but in any case, I think this is ready to take. |
|
Awesome, will merge in and bump version once you have rebased. Thanks! |
Details * Fixes #90 (nesquena/rabl issues tracker) * Plist: http://developer.apple.com/library/mac/#documentation/Cocoa/Conceptual/PropertyLists/Introduction/Introduction.htmlrubgems * Defaults to using the Ruby plist gem: http://rubygems.org/gems/plist * Adds Rabl configuration option include_plist_root which has same semantics as include_json_root. * Adds Rabl configuration option plist_engine which has similar semantics as json_engine. * Adds tests * Updated README.md to reflect the plist changes.
|
(rebased) |
|
Thanks, will merge this soon |
|
Merged and released 0.5.5.h. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
Very heavily based off #69 (thanks @byu )
I haven't had time to update the test cases yet, but I'll try and get around to it soon, otherwise patches welcome.