Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Add optional plist serialization format to Rabl #153

Merged
merged 1 commit into from Feb 16, 2012

Conversation

Projects
None yet
2 participants
Contributor

alzeih commented Jan 25, 2012

Details

Very heavily based off #69 (thanks @byu )
I haven't had time to update the test cases yet, but I'll try and get around to it soon, otherwise patches welcome.

Owner

nesquena commented Jan 26, 2012

Awesome work @alzeih . Once we can get some test cases in, I will merge this and release a version.

Owner

nesquena commented Feb 9, 2012

@alzeih Would love to add this in too. Any chance you'd have a chance to look at test cases akin to https://github.com/nesquena/rabl/blob/master/test/msgpack_engine_test.rb ?

Contributor

alzeih commented Feb 15, 2012

Added the test cases.
I'm no plist expert, but the output looks fairly sane. A couple of very minor fixes in that commit as well.

If you like, I will close this request and squash the two commits here and rebase on the current master - but in any case, I think this is ready to take.

Owner

nesquena commented Feb 15, 2012

Awesome, will merge in and bump version once you have rebased. Thanks!

@alzeih alzeih Add optional plist serialization format to Rabl
Details
* Fixes #90 (nesquena/rabl issues tracker)
* Plist: http://developer.apple.com/library/mac/#documentation/Cocoa/Conceptual/PropertyLists/Introduction/Introduction.htmlrubgems
* Defaults to using the Ruby plist gem: http://rubygems.org/gems/plist
* Adds Rabl configuration option include_plist_root which has same semantics as include_json_root.
* Adds Rabl configuration option plist_engine which has similar semantics as json_engine.
* Adds tests
* Updated README.md to reflect the plist changes.
68518de
Contributor

alzeih commented Feb 15, 2012

(rebased)

Owner

nesquena commented Feb 15, 2012

Thanks, will merge this soon

@nesquena nesquena merged commit 68518de into nesquena:master Feb 16, 2012

Owner

nesquena commented Feb 16, 2012

Merged and released 0.5.5.h. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment