Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix travis by upgrading bundler #662

Merged
merged 1 commit into from
Jun 14, 2016
Merged

Conversation

dgynn
Copy link
Collaborator

@dgynn dgynn commented Jun 14, 2016

I believe adding gem install bundler should resolve the Travis failures. (See rubygems/bundler#3560) I was able to recreate the failure and then resolve it with this commit.

This commit also drops ruby 1.8.7. There are tests that have syntax that requires 1.9 which will always fail so there is no point in running them.

I've also created another branch that runs the test:fixtures rake task instead of just test.
https://github.com/dgynn/rabl/tree/travis_with_fixtures
That branch is failing for various reasons although the majority of the tests pass for different combinations of Ruby and the frameworks/Gemfiles. The branch also drops support for Rails 2.x. Since those tests are failing I didn't want to make a PR for them but you can see the output here... https://travis-ci.org/dgynn/rabl/builds/137428066

@nesquena
Copy link
Owner

This is great thanks! So glad to see the basic tests passing again.

@nesquena nesquena merged commit 1c3671d into nesquena:master Jun 14, 2016
@Taher-Ghaleb
Copy link

Hello,

Sorry, I know it's been a long time ago, but I am curious why caching hasn't been enabled before this (i.e., since December 17, 2014, when it became available to open source projects).

Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants