Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I believe adding
gem install bundler
should resolve the Travis failures. (See rubygems/bundler#3560) I was able to recreate the failure and then resolve it with this commit.This commit also drops ruby 1.8.7. There are tests that have syntax that requires 1.9 which will always fail so there is no point in running them.
I've also created another branch that runs the
test:fixtures
rake task instead of justtest
.https://github.com/dgynn/rabl/tree/travis_with_fixtures
That branch is failing for various reasons although the majority of the tests pass for different combinations of Ruby and the frameworks/Gemfiles. The branch also drops support for Rails 2.x. Since those tests are failing I didn't want to make a PR for them but you can see the output here... https://travis-ci.org/dgynn/rabl/builds/137428066