Fix bug by using nodemailer-sendgrid #1133
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n from the constructor.
This was referenced Mar 8, 2024
IICarst
approved these changes
Apr 23, 2024
dkrantsberg
approved these changes
Apr 23, 2024
anthonyyoussef01
approved these changes
Apr 24, 2024
chaquentin
approved these changes
Apr 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I fixed the bug that occurred with nodemailer-sendgrid. I'm sorry, I had indeed run npm run test, but apart from connection error messages, I didn't notice any crashes, and I didn't test it with nodemailer-sendgrid.
So, I made it so that my function only executes if we specify an option 'verifyTransporters', which is false by default. This way, it won't be blocking. I also added an undefined check on the transporter.verify to avoid crashing.