Improve sign check

Fixes #825
nest · Jun 6, 2018 · 883a0a3 · 883a0a3
1 parent 5a841f0
commit 883a0a3
Showing 1 changed file with 1 addition and 2 deletions.
diff --git a/models/vogels_sprekeler_connection.h b/models/vogels_sprekeler_connection.h
@@ -298,8 +298,7 @@ VogelsSprekelerConnection< targetidentifierT >::set_status(
   updateValue< double >( d, names::Kplus, Kplus_ );
 
   // check if weight_ and Wmax_ has the same sign
-  if ( not( ( ( weight_ >= 0 ) - ( weight_ < 0 ) )
-         == ( ( Wmax_ >= 0 ) - ( Wmax_ < 0 ) ) ) )
+  if ( weight_ != 0 && not( ( weight_ > 0 ) == ( Wmax_ > 0 ) ) )
   {
     throw BadProperty( "Weight and Wmax must have same sign." );
   }