Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sphinx-tabs in documentation #1499

Closed
sarakonradi opened this issue Apr 3, 2020 · 5 comments · Fixed by #2288
Closed

Sphinx-tabs in documentation #1499

sarakonradi opened this issue Apr 3, 2020 · 5 comments · Fixed by #2288
Assignees
Labels
I: No breaking change Previously written code will work as before, no one should note anything changing (aside the fix) S: Normal Handle this with default priority stale Automatic marker for inactivity, please have another look here T: Discussion Still searching for the right way to proceed / suggestions welcome

Comments

@sarakonradi
Copy link
Contributor

This issue opens a discussion on whether or not we want to keep.. tabs:: in the documentation.

An example of where tabs are currently used can be found in the installation instructions for NEST: https://nest-simulator.readthedocs.io/en/latest/installation/index.html

Tabs could also prove useful in the Part 4 PyNEST tutorial, as they can show a snippet vs. figure view of on- and off-grids: https://nest-simulator.readthedocs.io/en/latest/tutorials/pynest_tutorial/part_4_spatially_structured_networks.html

The problem with tabs, however, is that they do not render well when printed to PDF or on GitHub: https://github.com/nest/nest-simulator/blob/master/doc/installation/index.rst

The issue follows up on an earlier conversation with @clinssen and @terhorstd in #1410.

@terhorstd terhorstd added ZC: Documentation DO NOT USE THIS LABEL I: No breaking change Previously written code will work as before, no one should note anything changing (aside the fix) ZP: Pending DO NOT USE THIS LABEL S: Normal Handle this with default priority T: Discussion Still searching for the right way to proceed / suggestions welcome labels Apr 3, 2020
@terhorstd terhorstd added this to To do in Documentation via automation Apr 3, 2020
@heplesser heplesser removed ZC: Documentation DO NOT USE THIS LABEL ZP: Pending DO NOT USE THIS LABEL labels Apr 7, 2020
@clinssen
Copy link
Contributor

It seems to be impossible to link directly to a particular tab. For example, from the NESTML documentation, I would like to link to the Anaconda installation instructions for NEST, but "conda" is on its own tab there (https://nest-simulator.readthedocs.io/en/stable/installation/index.html), so I can only link to the overall installation instructions page.

@sarakonradi
Copy link
Contributor Author

@clinssen Good that you are pointing this out; I hadn't thought of this issue before. Yes, you can only link the overall page that contains the tabs.

Perhaps, in the long run, it would make sense to remove the tabs and present the content in a different way. For example, rather than having one installation index, there could be two pages: "Standard installation instructions" and "Advanced installation instructions". Each page could present the information within the tabs in the form of subsections. There could also be a :local: table of contents listing the operating systems at the top.

Any alternative suggestions are welcome.

@heplesser
Copy link
Contributor

Given the problems with linking to tabs, I think we should remove tabs.

@terhorstd
Copy link
Contributor

In an extensive discussion during this week's hackathon, we confirmed the move away from tabs.
The discussion broadened to a collection of decisions that @sarakonradi will put in a *doStyle Guide among other points the result of the discussion regardin tabs was:

  • not use UI tabs, they hide information. If at all, use the harmonica "unfold section", even better is flat docs with right-side page index/TOC

@github-actions
Copy link

github-actions bot commented Sep 3, 2021

Issue automatically marked stale!

@github-actions github-actions bot added the stale Automatic marker for inactivity, please have another look here label Sep 3, 2021
Documentation automation moved this from To do to Done May 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
I: No breaking change Previously written code will work as before, no one should note anything changing (aside the fix) S: Normal Handle this with default priority stale Automatic marker for inactivity, please have another look here T: Discussion Still searching for the right way to proceed / suggestions welcome
Projects
Documentation
  
Done
Development

Successfully merging a pull request may close this issue.

5 participants