Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New test setup runs only minimal tests on macOS #2756

Closed
heplesser opened this issue May 2, 2023 · 0 comments · Fixed by #2762
Closed

New test setup runs only minimal tests on macOS #2756

heplesser opened this issue May 2, 2023 · 0 comments · Fixed by #2762
Assignees
Labels
I: No breaking change Previously written code will work as before, no one should note anything changing (aside the fix) S: High Should be handled next T: Enhancement New functionality, model or documentation

Comments

@heplesser
Copy link
Contributor

The new test setup created in #2590 only performs minimal checks under macOS, as it is built without support for MPI, OpenMP, GSL, Python (see https://github.com/nest/nest-simulator/actions/runs/4858443145/jobs/8659888539#step:8:11, https://github.com/nest/nest-simulator/actions/runs/4858443145/jobs/8659888539#step:12:295). It should run the full set of tests except those requiring sionlib, music, libneurosim.

See also #2660 for fixes to the old CI setup that allowed running test with OpenMP again under macOS. The crucial point was to inform Cmake about the location of the OpenMP library installed by Homebrew:

CONFIGURE_OPENMP="${CONFIGURE_OPENMP} -DOpenMP_ROOT=`brew --prefix libomp`"

I'd create a PR myself but feel a bit uncertain about the new setup, so I create this issue.

@heplesser heplesser added T: Enhancement New functionality, model or documentation S: High Should be handled next I: No breaking change Previously written code will work as before, no one should note anything changing (aside the fix) labels May 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
I: No breaking change Previously written code will work as before, no one should note anything changing (aside the fix) S: High Should be handled next T: Enhancement New functionality, model or documentation
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants