Fix OpenMP issues on CI under macOS and re-activate testing with threads for macOS #2660
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ads on macOS.
Co-authored-by: Nicolai Haug <39106781+nicolossus@users.noreply.github.com>
heplesser
added
S: High
Looks good to me. Yes, I think I have added brew info line in the initial phase to get the package information. This is not at all necessary. Use of |
This was referenced May 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the CI build of NEST under macOS by providing the location of the OpenMP lib through a
brew --prefixquery. It also re-activates testing with threads under macOS. A meaninglessbrew infoline is removed—it only printed canned package information.This fixes #2515.
PR developed in collaboration with @nicolossus.