ConnBuilder loop_over_targets() does not work as intended #3106
Labels
I: No breaking change
Previously written code will work as before, no one should note anything changing (aside the fix)
S: High
Should be handled next
stale
Automatic marker for inactivity, please have another look here
T: Bug
Wrong statements in the code or documentation
Projects
Following Ippen et al (2017, Sec 3.2), ConnBuilders should loop over local nodes instead of over targets when the number of local nodes is smaller than the target population. Unfortunately, ever since 20b8f33, the
loop_over_targets()
method looks like this (see here in context)Here,
kernel().node_manager.size()
returns the size of the entire network, so the condition will always be true unlesstargets
contains the entire network. This is not what is intended.I have not checked fully, but I believe we should compare
targets.size()
to the number of nodes on the pertaining thread.The text was updated successfully, but these errors were encountered: