Correct errors in slicing of node collections #3132
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…me; first version passing all tests
heplesser
added
T: Bug
…ad of filtering according to slicing in a second step.
This reverts commit 33fa658.
heplesser
changed the title
gtrensch
approved these changes
Mar 12, 2024
heplesser
force-pushed
the
fix_nc_slicing
branch
2 times, most recently
from
07a9890
to
26c96b7
Compare
heplesser
force-pushed
the
fix_nc_slicing
branch
from
26c96b7
to
82d25d2
Compare
|
@gtrensch @jstapmanns @diesmann After much hard work, I believe I have solved all problems now and that the testsuite is broad enough to cover all eventualities. Kindly review the new version of the PR. I suggest you start with the documentation near the beginning of |
heplesser
force-pushed
the
fix_nc_slicing
branch
from
8b3578a
to
2619c3f
Compare
heplesser
force-pushed
the
fix_nc_slicing
branch
4 times, most recently
from
7123538
to
abeb018
Compare
…ithub Linux runners due to performance issues; the tests are run under macOS
heplesser
force-pushed
the
fix_nc_slicing
branch
from
abeb018
to
e0b5ed4
Compare
…thub now is macOS 14 and only 3.10 and later are available
|
@gtrensch @jstapmanns Ping! |
|
The author of the original model with which the problem was originally discovered has reported that the full model now works perfectly! |
jstapmanns
reviewed
May 17, 2024
There was a problem hiding this comment.
Thank you, @heplesser, for implementing these slicing algorithms. In general, I'm pretty confident they do what they are supposed to do, but I still have a question about the example given in the description (which I find very helpful to understand the implementation).
| * All thr 2 * | * * | ||
| * All thr 3 * | * * | ||
| * ----------------------------------------------------------------- | ||
| * [::3] 1stInPt # | # |
There was a problem hiding this comment.
I have two questions regarding this example.
- To my understanding,
[::3] 1stInPtshould point to the object withGID = 9because
n_pe = 1 + ( cumul_abs_size_[ part_idx_ - 1 ] - 1 - first_elem_ ) / stride = 1 + (5-1-0)/3 = 2, so thatnext_abs_idx = first_elem_ + n_pe * stride_ = 0 + 2*3 = 6, and finally
next_loc_idx = next_abs_idx - cumul_abs_size_[ part_idx_ - 1 ] = 6 - 5 = 1. - I think I do not completely understand the behavior of the local iterators. Shouldn't
[::3] thr 2yield every third element that is local to thread 2? In this case, objects withGID=[2, 10, 14]are on thread 2, which would mean[::3] thr 2 = [2]. Similarly for thread 3, whereGID=[3, 14, 15].
gtrensch
approved these changes
May 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #3108 by providing correct
NodeCollection::{rank,thread}_local_begin(()implementations for composite node collections.To do:
slice_positions_if_sliced_nc()code to more suitable locationI removed the ConnBuilder refactoring (see #3106) from this PR to reduce complexity and ensure we can integrate this bug-fixing PR asap. The refactoring can then following in a later PR.