Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct input handling for gif_cond_exp_multisynapse #511

Closed
heplesser opened this issue Oct 6, 2016 · 0 comments · Fixed by #579
Closed

Correct input handling for gif_cond_exp_multisynapse #511

heplesser opened this issue Oct 6, 2016 · 0 comments · Fixed by #579
Assignees
Labels
I: User Interface Users may need to change their code due to changes in function calls S: High Should be handled next T: Maintenance Work to keep up the quality of the code and documentation. ZC: Model DO NOT USE THIS LABEL ZP: PR Created DO NOT USE THIS LABEL
Milestone

Comments

@heplesser
Copy link
Contributor

This issues becomes relevant once #261 is merged.

Input handling for gif_cond_exp_multisynapse needs to be modified according to the decision made in the NEST Developer VC 19 Sep 2016:

  • Replace E_ex, E_in with vector of reversal potentials the same size as taus_syn (one per synapse)
  • Replace I_syn_ex, I_syn_in recordables with one recordable I_syn representing the total input current
  • Update class and handle(SpikeEvent&) to a single input buffer per rport, see aeif_cond_beta_multisynapse for an example; consider adding a check for non-negative weight.
  • Update *_dynamics function to handle input current correctly, along the lines of
  double I_syn = 0.0;
  for ( size_t i = 0; i < node.P_.num_of_receptors_ ; ++i )
  {
      I_syn += y[ S::G + i ] * ( node.P_.E_rev[i] - V );
  }
  • Move *_dynamics function to cpp-file.
  • Provide examples (python based).

See also #509, #510.

@heplesser heplesser added ZC: Model DO NOT USE THIS LABEL I: User Interface Users may need to change their code due to changes in function calls ZP: Pending DO NOT USE THIS LABEL S: High Should be handled next T: Maintenance Work to keep up the quality of the code and documentation. labels Nov 17, 2016
@heplesser heplesser added this to the NEST 2.12 milestone Nov 17, 2016
@heplesser heplesser self-assigned this Nov 21, 2016
@heplesser heplesser added ZP: In progess DO NOT USE THIS LABEL and removed ZP: Pending DO NOT USE THIS LABEL labels Dec 5, 2016
@heplesser heplesser added ZP: PR Created DO NOT USE THIS LABEL and removed ZP: In progess DO NOT USE THIS LABEL labels Dec 7, 2016
heplesser added a commit that referenced this issue Dec 9, 2016
Correct input handling for gif_cond_exp_multisynapse (fixes #511)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
I: User Interface Users may need to change their code due to changes in function calls S: High Should be handled next T: Maintenance Work to keep up the quality of the code and documentation. ZC: Model DO NOT USE THIS LABEL ZP: PR Created DO NOT USE THIS LABEL
Projects
No open projects
Development

Successfully merging a pull request may close this issue.

2 participants