Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ConnectLayers does not connect to thread siblings of devices #665

Closed
heplesser opened this issue Feb 27, 2017 · 1 comment
Closed

ConnectLayers does not connect to thread siblings of devices #665

heplesser opened this issue Feb 27, 2017 · 1 comment
Assignees
@heplesser
Labels
I: No breaking change Previously written code will work as before, no one should note anything changing (aside the fix) S: High Should be handled next T: Bug Wrong statements in the code or documentation ZC: Kernel DO NOT USE THIS LABEL ZP: PR Created DO NOT USE THIS LABEL
Milestone
NEST 2.12

Comments

@heplesser
Copy link
Contributor

In multithreaded simulations, ConnectLayers does not connect to thread siblings of devices. The following code:

0 << /local_num_threads 4 >> SetStatus

/nrns << /elements /iaf_psc_alpha /rows 2 /columns 2 >> CreateLayer def
/det << /elements /spike_detector /rows 1 /columns 1 >> CreateLayer def
nrns det  << /connection_type /convergent >> ConnectLayers

<< >> GetConnections ==

will connect only the neuron managed by thread 0 (neuron with GID 4) to the spike detector (instance on thread 0):

[<4,7,0,0,0>]

The other neurons should be connected to the thread-siblings of the spike detector on their respective threads. This is a regression from NEST 2.10, which created all connections:

[<5,7,1,0,0> <3,7,3,0,0> <2,7,2,0,0> <4,7,0,0,0>]

Originally reported by Elena Pastorelli on NEST User 20 Feb 2017.
@heplesser heplesser self-assigned this Feb 27, 2017
@heplesser heplesser added ZC: Kernel DO NOT USE THIS LABEL I: No breaking change Previously written code will work as before, no one should note anything changing (aside the fix) ZP: In progess DO NOT USE THIS LABEL S: High Should be handled next T: Bug Wrong statements in the code or documentation labels Feb 27, 2017
@heplesser heplesser added this to the NEST 2.12 milestone Feb 27, 2017
heplesser added a commit to heplesser/nest-simulator that referenced this issue Feb 28, 2017
@heplesser
Fix for nest#665 including updated topology manual.
88ca8d6
@heplesser heplesser mentioned this issue Feb 28, 2017
Merged
@heplesser heplesser added ZP: PR Created DO NOT USE THIS LABEL and removed ZP: In progess DO NOT USE THIS LABEL labels Feb 28, 2017
@terhorstd
Copy link
Contributor

closed by merge of #666

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@heplesser heplesser

Labels
I: No breaking change Previously written code will work as before, no one should note anything changing (aside the fix) S: High Should be handled next T: Bug Wrong statements in the code or documentation ZC: Kernel DO NOT USE THIS LABEL ZP: PR Created DO NOT USE THIS LABEL
Projects
None yet
Milestone
NEST 2.12
Development

No branches or pull requests
2 participants
@heplesser @terhorstd