Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ConnectionCreator::target_driven_connect_ does not handle exceptions correctly #977

Closed
heplesser opened this issue Jun 18, 2018 · 2 comments
Closed

ConnectionCreator::target_driven_connect_ does not handle exceptions correctly #977

heplesser opened this issue Jun 18, 2018 · 2 comments
Labels
I: No breaking change Previously written code will work as before, no one should note anything changing (aside the fix) S: Normal Handle this with default priority T: Maintenance Work to keep up the quality of the code and documentation. ZC: Kernel DO NOT USE THIS LABEL ZP: Pending DO NOT USE THIS LABEL

Comments

@heplesser
Copy link
Contributor

ConnectionCreator::target_driven_connect_() does not catch exceptions inside the thread-parallel context and re-throw the outside. This may lead to a crash if an exception is thrown while connections are created.
@heplesser heplesser added ZC: Kernel DO NOT USE THIS LABEL ZP: Pending DO NOT USE THIS LABEL S: Normal Handle this with default priority T: Maintenance Work to keep up the quality of the code and documentation. I: No breaking change Previously written code will work as before, no one should note anything changing (aside the fix) labels Jun 18, 2018
@stinebuu
Copy link
Contributor

stinebuu commented Jun 19, 2018 •
edited
Loading

@heplesser As a side note, this is implemented in the SubnetFreeTopology branch, so if this issue is not fixed by the time the subnetFree branch is merged into master, it will be fixed then.

@terhorstd
Copy link
Contributor

this is fixed in NEST-3 branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
I: No breaking change Previously written code will work as before, no one should note anything changing (aside the fix) S: Normal Handle this with default priority T: Maintenance Work to keep up the quality of the code and documentation. ZC: Kernel DO NOT USE THIS LABEL ZP: Pending DO NOT USE THIS LABEL
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@heplesser @terhorstd @stinebuu