Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move ConnectionManager methods from impl to h #1029

Merged
merged 1 commit into from Sep 26, 2018
Merged

Move ConnectionManager methods from impl to h #1029

merged 1 commit into from Sep 26, 2018

Conversation

jakobj
Copy link
Contributor

@jakobj jakobj commented Sep 14, 2018

Just maintanance: this PR moves four methods that were unnecessarily put into the impl file. @hakonsbm @stinebuu could you review please?

stinebuu
stinebuu approved these changes Sep 17, 2018
View reviewed changes
Copy link
Contributor

@stinebuu stinebuu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems fine to me! 👍

heplesser
heplesser reviewed Sep 17, 2018
View reviewed changes
nestkernel/connection_manager.h
{
connections_[ tid ][ syn_id ]->send( tid, lcid, cm, e );
}
inline void
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Insert empty line here.

@heplesser heplesser added ZC: Kernel DO NOT USE THIS LABEL ZP: PR Created DO NOT USE THIS LABEL S: Normal Handle this with default priority T: Maintenance Work to keep up the quality of the code and documentation. I: No breaking change Previously written code will work as before, no one should note anything changing (aside the fix) labels Sep 17, 2018
heplesser
heplesser requested changes Sep 21, 2018
View reviewed changes
Copy link
Contributor

@heplesser heplesser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See inline comment, method definitions need to be separated by empty lines.

@jakobj jakobj force-pushed the fix/remove-functions-from-impl branch from 71c7bb6 to 28f7843 Compare September 26, 2018 08:36
@jakobj jakobj force-pushed the fix/remove-functions-from-impl branch from 28f7843 to e3e419c Compare September 26, 2018 08:38
@jakobj
Copy link
Contributor Author

jakobj commented Sep 26, 2018

done.

@heplesser heplesser merged commit 6a89926 into nest:master Sep 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@heplesser heplesser heplesser approved these changes

@hakonsbm hakonsbm hakonsbm approved these changes

@stinebuu stinebuu stinebuu approved these changes

Assignees
No one assigned
Labels
I: No breaking change Previously written code will work as before, no one should note anything changing (aside the fix) S: Normal Handle this with default priority T: Maintenance Work to keep up the quality of the code and documentation. ZC: Kernel DO NOT USE THIS LABEL ZP: PR Created DO NOT USE THIS LABEL
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@jakobj @heplesser @hakonsbm @stinebuu