Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unify coeffarray_as_d and coeffarray_as_uint via Union #1243

Merged
merged 1 commit into from Aug 5, 2019
Merged

Unify coeffarray_as_d and coeffarray_as_uint via Union #1243

merged 1 commit into from Aug 5, 2019

Conversation

jakobj
Copy link
Contributor

@jakobj jakobj commented Jun 29, 2019

The begin and end iterators of both coeffarray_as_d and coeffarray_as_uint always refer to the same data. Keeping them separately as it was done previously can lead to strange errors when the as_d iterators are set and one is trying to access the data via the as_uint iterators.

I suggest @janhahne @clinssen as reviewers

@jakobj
Unify coeffarray_as_d and coeffarray_as_uint via Union
69231fd 
The begin and end iterators of both coeffarray_as_d and coeffarray_as_uint
always refer to the same data.
@jakobj jakobj mentioned this pull request Jul 1, 2019
Merged
janhahne
janhahne approved these changes Jul 3, 2019
View reviewed changes
Copy link
Contributor

@janhahne janhahne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is indeed much cleaner, thanks for the effort!

@jougs jougs requested a review from clinssen July 22, 2019 10:13
@jougs jougs added ZC: Kernel DO NOT USE THIS LABEL I: Internal API Changes were introduced in basic internal workings of the simulator that developers need to know ZP: PR Created DO NOT USE THIS LABEL S: Normal Handle this with default priority T: Maintenance Work to keep up the quality of the code and documentation. labels Jul 22, 2019
clinssen
clinssen approved these changes Jul 23, 2019
View reviewed changes
Copy link
Contributor

@clinssen clinssen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks indeed much cleaner, thanks!

@terhorstd terhorstd merged commit e4f6b32 into nest:master Aug 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@janhahne janhahne janhahne approved these changes

@clinssen clinssen clinssen approved these changes

Assignees
No one assigned
Labels
I: Internal API Changes were introduced in basic internal workings of the simulator that developers need to know S: Normal Handle this with default priority T: Maintenance Work to keep up the quality of the code and documentation. ZC: Kernel DO NOT USE THIS LABEL ZP: PR Created DO NOT USE THIS LABEL
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@jakobj @janhahne @clinssen @jougs @terhorstd