Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to GCC8 as default in continuous integration tests on Travis #1310

Merged
merged 12 commits into from
Oct 28, 2019

Conversation

clinssen
Copy link
Contributor

Fixes #1309.

@ikitayama
Copy link

ikitayama commented Oct 14, 2019 via email

@clinssen
Copy link
Contributor Author

@ikitayama: the reason we upgraded GCC was because there was a specific reason to do so: we were running into a compiler bug on the previous version. In general, I believe our policy is a conservative one, and we only upgrade if there is a compelling reason for it. If you can make the case for clang 9, then of course please be invited to do so!

@terhorstd terhorstd added ZC: Infrastructure DO NOT USE THIS LABEL I: No breaking change Previously written code will work as before, no one should note anything changing (aside the fix) ZP: PR Created DO NOT USE THIS LABEL S: Normal Handle this with default priority T: Maintenance Work to keep up the quality of the code and documentation. labels Oct 14, 2019
@ikitayama
Copy link

ikitayama commented Oct 14, 2019 via email

Copy link
Contributor

@lekshmideepu lekshmideepu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed the issue with the OsX build. Looks good to me. 👍

Copy link
Contributor

@heplesser heplesser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@clinssen Looks good to me except for one comment, see below.

Comment on lines 23 to 26
The default compiler for NEST is GNU gcc/g++. Version 7 or higher is required
due to the presence of bugs in earlier versions that prevent the compilation
from succeeding. NEST has also successfully been compiled with other
compilers, including Intel icc/icpc, Pathscale, Portland and IBM compilers.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should update the list of "other compilers" mentioned here. First, we definitely should mention Clang, since we now explicitly test with it. Some of us probably use the Intel compiler occasionally, but I think it is a long time since anyone has tested Pathscale, Portland and probably also IBM, so I would take those out.

@ikitayama
Copy link

ikitayama commented Oct 21, 2019 via email

@terhorstd terhorstd changed the title GCC8 on Travis CI Switch to GCC8 as default in continuous integration tests on Travis Oct 28, 2019
@terhorstd terhorstd merged commit f28b138 into nest:master Oct 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
I: No breaking change Previously written code will work as before, no one should note anything changing (aside the fix) S: Normal Handle this with default priority T: Maintenance Work to keep up the quality of the code and documentation. ZC: Infrastructure DO NOT USE THIS LABEL ZP: PR Created DO NOT USE THIS LABEL
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update gcc version in Travis CI
5 participants