-
Notifications
You must be signed in to change notification settings - Fork 358
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch to GCC8 as default in continuous integration tests on Travis #1310
Conversation
May I ask why Clang 7 is still the choice for CI/CD on Travis as Clang 9 is
out in the fields?
…On Mon, Oct 14, 2019 at 17:31 clinssen ***@***.***> wrote:
Fixes #1309 <#1309>.
------------------------------
You can view, comment on, or merge this pull request online at:
#1310
Commit Summary
- GCC8 on Travis CI
File Changes
- *M* .travis.yml
<https://github.com/nest/nest-simulator/pull/1310/files#diff-0> (25)
Patch Links:
- https://github.com/nest/nest-simulator/pull/1310.patch
- https://github.com/nest/nest-simulator/pull/1310.diff
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#1310?email_source=notifications&email_token=AAHLBZZCXTHZAW7XGDEQTGTQOQU6LA5CNFSM4JAMCS62YY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4HRQYZSQ>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAHLBZ7ZO7FEE6PBG4SMIN3QOQU6LANCNFSM4JAMCS6Q>
.
|
@ikitayama: the reason we upgraded GCC was because there was a specific reason to do so: we were running into a compiler bug on the previous version. In general, I believe our policy is a conservative one, and we only upgrade if there is a compelling reason for it. If you can make the case for clang 9, then of course please be invited to do so! |
Then I’d think we can creat an edge CI/CD with the latest stable Clang,
keeping the stable one with Ckang 7, unless the resource is serveky limited.
…On Mon, Oct 14, 2019 at 18:17 clinssen ***@***.***> wrote:
@ikitayama <https://github.com/ikitayama>: the reason we upgraded GCC was
because there was a specific reason to do so: we were running into a
compiler bug on the previous version. In general, I believe our policy is a
conservative one, and we only upgrade if there is a compelling reason for
it. If you can make the case for clang 9, then of course please be invited
to do so!
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#1310?email_source=notifications&email_token=AAHLBZ3CZ54RULEZIXLWWZTQOQ2JZA5CNFSM4JAMCS62YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEBD3R6Y#issuecomment-541571323>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAHLBZ7EEYJ4FTWZQMHRG4TQOQ2JZANCNFSM4JAMCS6Q>
.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed the issue with the OsX build. Looks good to me. 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@clinssen Looks good to me except for one comment, see below.
doc/installation/install_options.rst
Outdated
The default compiler for NEST is GNU gcc/g++. Version 7 or higher is required | ||
due to the presence of bugs in earlier versions that prevent the compilation | ||
from succeeding. NEST has also successfully been compiled with other | ||
compilers, including Intel icc/icpc, Pathscale, Portland and IBM compilers. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should update the list of "other compilers" mentioned here. First, we definitely should mention Clang, since we now explicitly test with it. Some of us probably use the Intel compiler occasionally, but I think it is a long time since anyone has tested Pathscale, Portland and probably also IBM, so I would take those out.
I’m using XL on JURON at JSC.
…On Tue, Oct 22, 2019 at 3:25 Hans Ekkehard Plesser ***@***.***> wrote:
***@***.**** requested changes on this pull request.
@clinssen <https://github.com/clinssen> Looks good to me except for one
comment, see below.
------------------------------
In doc/installation/install_options.rst
<#1310 (comment)>:
> +The default compiler for NEST is GNU gcc/g++. Version 7 or higher is required
+due to the presence of bugs in earlier versions that prevent the compilation
+from succeeding. NEST has also successfully been compiled with other
+compilers, including Intel icc/icpc, Pathscale, Portland and IBM compilers.
We should update the list of "other compilers" mentioned here. First, we
definitely should mention Clang, since we now explicitly test with it. Some
of us probably use the Intel compiler occasionally, but I think it is a
long time since anyone has tested Pathscale, Portland and probably also
IBM, so I would take those out.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#1310?email_source=notifications&email_token=AAHLBZ5C525TZFMMR24U7C3QPXXY3A5CNFSM4JAMCS62YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCIVEAIA#pullrequestreview-304758816>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAHLBZ7J4COGM7EOFLGEW3TQPXXY3ANCNFSM4JAMCS6Q>
.
|
Fixes #1309.