-
Notifications
You must be signed in to change notification settings - Fork 357
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding framework for compartmental models #1895
Conversation
Remove lag from synapse, pass in update()
Pass tree structure and compartment properties from SLI
[WIP] First synapse model
Move tests of comptree to cpp test, reduce coupling of comptree and nest
Readd synapse tests
@WillemWybo, please fix the formatting errors either manually or by installing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Many thanks for this wonderful addition and the endurance during the review process ;-)
Just one additional request from my side: Can you please add a paragraph about the new models (possibly with a short example?) to the release notes for NEST 3.3, so users can discover them more easily?
Added it to the release notes! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Many thanks for this contribution. |
The present PR implements compartmental models (cm) for NEST. It adds a family of files, prefixed by 'cm_' to the
models/
directory. These files implement the cm.Furthermore, the PR adds tests for the cm (
pynest/nest/tests/test_compartmental_model.py
), as well as examples (pynest/examples/compartmental_model
).The dendritic structure (branching, parameters,...) is determined by the user at runtime. For this, the PR adds a function
nest.AddCompartment()
to the python API, as well as a functionnest.AddReceptor()
, which allows the user to add one of three receptor types ('AMPA', 'GABA' or 'AMPA+NMDA'). The number of receptors to a compartment is entirely user-defined.Currently, both the ion-channels and receptors types are hard-coded into the model. We are working to include user-specified ion-channels and receptor types through NESTML. This NESTML functionality will then render the specific versions of
models/cm_etype.*
andmodels/cm_syns.*
implemented here obsolete.