Correctly connect MUSIC output proxies when using multiple MPI processes in NEST #1983
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
heplesser
added
T: Bug
…fix-1974-music-out
…tor into fix-1974-music-out
|
Pull request automatically marked stale! |
github-actions
bot
added
the
stale
|
@heplesser: Is there any progress on this? Would it be an option to close and re-open once you get around to it? |
github-actions
bot
removed
the
stale
|
Pull request automatically marked stale! |
github-actions
bot
added
the
stale
|
Friendly ping! |
github-actions
bot
removed
the
stale
|
Pull request automatically marked stale! |
github-actions
bot
added
the
stale
|
@jougs @mdjurfeldt I finally added the regression test (much easier than I had feared ...), so this one is ready for review. Several files in the diff (esp in models) only pop up here due to formatting corrections. |
github-actions
bot
removed
the
stale
jougs
approved these changes
May 12, 2022
There was a problem hiding this comment.
I only have a small spelling fix, but am fine otherwise. @mdjurfeldt could you please quickly review and indicate if you're fine with this? Thanks!
Co-authored-by: Jochen Martin Eppler <jougs@gmx.net>
Co-authored-by: Jochen Martin Eppler <jougs@gmx.net>
mdjurfeldt
approved these changes
May 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #1974.
This is still a draft because I still need to add regression tests.