Add warning about synaptic plasticity mechanisms and precise spike timing #2137
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nto account warning
jessica-mitchell
requested changes
Aug 30, 2021
There was a problem hiding this comment.
@clinssen looks good; Aside from a minor comment about wording, I noticed that the equations don't seem to render properly. The only thing looking a bit off is the lack of \\ at the end of the first line. Not sure if that will solve it.
models/jonke_synapse.h
Outdated
| F_-(t) &= \exp((t - t_j^(k))/\tau_-) | ||
|
|
||
| This makes it possible to implement update rules which approximate the | ||
| rule of [1]_, e.g. the rules given in [2]_ and [3]_. |
There was a problem hiding this comment.
Suggested change
| rule of [1]_, e.g. the rules given in [2]_ and [3]_. | |
| rule stated in [1]_, and for examples, the rules given in [2]_ and [3]_. |
…nto account warning
|
jessica-mitchell
approved these changes
Aug 31, 2021
heplesser
approved these changes
Sep 3, 2021
terhorstd
added
S: Normal
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Spin-off from #1840. For now, synaptic plasticity mechanisms will continue to ignore precise spike timing, because changing this is a larger project that raises further questions (to be addressed in #2035). To prevent confusion in the mean time, this PR adds warnings about this behaviour to all synaptic plasticity models that are affected.