Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add STDP dopamine synapse unit testing #2168

Draft
wants to merge 16 commits into
base: master
Choose a base branch
from
Draft

Add STDP dopamine synapse unit testing #2168

wants to merge 16 commits into from

Conversation

YounesBouhadjar
Copy link
Contributor

@YounesBouhadjar YounesBouhadjar commented Sep 19, 2021 •
edited
Loading

This adds a unit test for the STDP dopamine synapse. It compares the weight evolution due to pre-, post, and dopamine spikes between NEST and a Python reference implementation.

Todo

Test stimuli:

  • stimulating the pre, post neurons as well as the dopa release site using a Poisson generator
  • hard-coded edge cases the pre and post spikes
  • hard-coded edge cases for the dopa spikes

Neuron models:

  • iaf_psc_exp
  • iaf_cond_exp

Most of the code here is inspired by the STDP unit testing.
fixes #820

@stinebuu stinebuu added I: No breaking change Previously written code will work as before, no one should note anything changing (aside the fix) S: Normal Handle this with default priority T: Enhancement New functionality, model or documentation labels Sep 29, 2021
@stinebuu stinebuu added this to To do in Models via automation Sep 29, 2021
@clinssen clinssen self-requested a review October 4, 2021 17:40
@YounesBouhadjar
Copy link
Contributor Author

When printing the c and the n traces of both the NEST and the Python reference implementation, I see that the c trace is the one that differs considerably between the two implementations.

@github-actions
Copy link

Pull request automatically marked stale!

@github-actions github-actions bot added the stale Automatic marker for inactivity, please have another look here label Jan 29, 2022
@clinssen clinssen requested a review from pnbabu March 7, 2022 09:51
@heplesser
Copy link
Contributor

@YounesBouhadjar Could you fix the static check problems?

@clinssen @pnbabu Ping!

@clinssen clinssen mentioned this pull request Apr 21, 2022
Closed
@github-actions github-actions bot removed the stale Automatic marker for inactivity, please have another look here label Apr 22, 2022
@github-actions
Copy link

Pull request automatically marked stale!

@github-actions github-actions bot added the stale Automatic marker for inactivity, please have another look here label Jun 28, 2022
@terhorstd
Copy link
Contributor

@YounesBouhadjar, do you have a status update on this one?

@YounesBouhadjar
Copy link
Contributor Author

@terhorstd I will hopefully pick up this again soon, sorry for the delay.

@github-actions github-actions bot removed the stale Automatic marker for inactivity, please have another look here label Aug 3, 2022
@YounesBouhadjar YounesBouhadjar marked this pull request as draft August 6, 2022 10:10
@github-actions
Copy link

Pull request automatically marked stale!

@github-actions github-actions bot added the stale Automatic marker for inactivity, please have another look here label Oct 12, 2022
@heplesser
Copy link
Contributor

@YounesBouhadjar Ping!

@YounesBouhadjar
Copy link
Contributor Author

YounesBouhadjar commented Nov 25, 2022 •
edited
Loading

I'm still not able to solve the mismatch between NEST and the Python reference implementation. The mismatch occurs only for the hardcoded edge cases at places where the presynaptic and postsynaptic spikes are very close to each other.
@clinssen could you take a look at that?

@github-actions github-actions bot removed the stale Automatic marker for inactivity, please have another look here label Nov 26, 2022
@clinssen clinssen moved this from To do to In progress in Models Nov 29, 2022
@jougs
Copy link
Contributor

jougs commented Jan 12, 2023

Any news on this?

@YounesBouhadjar
Copy link
Contributor Author

@jougs we are still working on this.

@github-actions
Copy link

Pull request automatically marked stale!

@github-actions github-actions bot added the stale Automatic marker for inactivity, please have another look here label Mar 14, 2023
@clinssen clinssen moved this from In progress to To do in Models Jul 3, 2023
@YounesBouhadjar YounesBouhadjar mentioned this pull request Jul 9, 2023
Merged
@heplesser
Copy link
Contributor

@YounesBouhadjar Any progress or plans on this? Would be nice to get it merged. It there are still some corner cases missing, we could always delegate those to a follow-up issue.

@YounesBouhadjar
Copy link
Contributor Author

@heplesser thanks for the reminder, sorry that this PR is taking too long.
I'm working on it again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clinssen clinssen Awaiting requested review from clinssen

@pnbabu pnbabu Awaiting requested review from pnbabu

Assignees
No one assigned
Labels
I: No breaking change Previously written code will work as before, no one should note anything changing (aside the fix) S: Normal Handle this with default priority stale Automatic marker for inactivity, please have another look here T: Enhancement New functionality, model or documentation
Projects
Models
  
To do
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unittest of dopamine synapse model
5 participants
@YounesBouhadjar @heplesser @terhorstd @jougs @stinebuu