Remove erroneous check in stimulation device base class #2172
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jougs
reviewed
Sep 28, 2021
There was a problem hiding this comment.
Thanks for your contribution. The change in this PR looks good to me.
Given the potential for future problems, I wonder if we should add a test to testsuite/pytests that checks the expected behavior for all stimulation devices. Could you please comment on this?
jougs
added
I: External API
jougs
changed the title
|
Dear @jougs thanks for taking a look at the PR. We can indeed try to design a test suite for stimulation devices. I think the normal functionality without the new IO backends is already quite well tested within other tests but there are some cosim specific features which might be important to keep in check. |
|
Merging after an offline discussion with @sdiazpier. Tests will be added in a follow-up PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR solves issue 83 from EBRAINS-cosim. A control had been added by mistake to the stimulation devices during the integration of the current version of NEST I/O. This control did not allow changing the status of the device once it had been initialized.