Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Distribute node positions over MPI processes #2181

Merged
merged 47 commits into from
Nov 11, 2021
Merged

Distribute node positions over MPI processes #2181

merged 47 commits into from
Nov 11, 2021

Conversation

hakonsbm
Copy link
Contributor

@hakonsbm hakonsbm commented Oct 8, 2021 •
edited

Node positions are with this PR stored only on the process where the corresponding node is created. This fixes #2174.

@hakonsbm hakonsbm added T: Bug Wrong statements in the code or documentation S: Critical Needs to be addressed immediately I: No breaking change Previously written code will work as before, no one should note anything changing (aside the fix) labels Oct 8, 2021
@hakonsbm hakonsbm added this to the NEST 3.2 milestone Oct 8, 2021
@hakonsbm hakonsbm added this to PRs in progress in Kernel via automation Oct 8, 2021
stinebuu
stinebuu suggested changes Oct 13, 2021
View reviewed changes
Copy link
Contributor

@stinebuu stinebuu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I have some suggestions and questions :)

nestkernel/free_layer.h Outdated Show resolved Hide resolved
nestkernel/free_layer.h Outdated Show resolved Hide resolved
nestkernel/free_layer.h Outdated Show resolved Hide resolved
nestkernel/spatial.cpp Outdated Show resolved Hide resolved
testsuite/mpitests/topo_mpi_test_pairwise_bernoulli_on_source_param.sli Outdated Show resolved Hide resolved
testsuite/mpitests/topo_mpi_test_pairwise_bernoulli_on_source_param.sli Outdated Show resolved Hide resolved
testsuite/pytests/test_connect_symmetric_pairwise_bernoulli.py Outdated Show resolved Hide resolved
Kernel automation moved this from PRs in progress to PRs pending approval Oct 13, 2021
stinebuu
stinebuu approved these changes Oct 22, 2021
View reviewed changes
Copy link
Contributor

@stinebuu stinebuu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

Kernel automation moved this from PRs pending approval to PRs approved Oct 22, 2021
@hakonsbm hakonsbm mentioned this pull request Nov 4, 2021
Closed
heplesser
heplesser requested changes Nov 10, 2021
View reviewed changes
Copy link
Contributor

@heplesser heplesser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @hakonsbm! Thanks a lot! Now I just have a few small suggestions left, then this should be ready :).

lib/sli/nest-init.sli Outdated Show resolved Hide resolved
lib/sli/nest-init.sli Outdated Show resolved Hide resolved
lib/sli/nest-init.sli Outdated Show resolved Hide resolved
nestkernel/nestmodule.cpp Outdated Show resolved Hide resolved
nestkernel/node_collection.h Outdated Show resolved Hide resolved
pynest/nest/lib/hl_api_types.py Outdated Show resolved Hide resolved
pynest/nest/lib/hl_api_types.py Outdated Show resolved Hide resolved
pynest/nest/lib/hl_api_types.py Outdated Show resolved Hide resolved
hakonsbm and others added 2 commits November 10, 2021 11:04
@hakonsbm
Changed logic to convert all negative indices to positive
a46e8f9 
Also added comments.
@hakonsbm @heplesser
Apply suggestions from code review
8b4e01f 
Co-authored-by: Hans Ekkehard Plesser <hans.ekkehard.plesser@nmbu.no>
stinebuu
stinebuu reviewed Nov 10, 2021
View reviewed changes
Copy link
Contributor

@stinebuu stinebuu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I only have some suggestions to changes to some of the comments.

nestkernel/free_layer.h Outdated Show resolved Hide resolved
nestkernel/nestmodule.cpp Outdated Show resolved Hide resolved
testsuite/pytests/test_NodeCollection.py Outdated Show resolved Hide resolved
testsuite/pytests/test_NodeCollection.py Outdated Show resolved Hide resolved
testsuite/pytests/test_NodeCollection.py Outdated Show resolved Hide resolved
hakonsbm and others added 2 commits November 10, 2021 15:28
@hakonsbm
Removed trailing whitespace
e540919
@hakonsbm @stinebuu
Apply suggestions from code review
d2a7d64 
Co-authored-by: Stine Brekke Vennemo <stine.vennemo@gmail.com>
heplesser
heplesser approved these changes Nov 11, 2021
View reviewed changes
Copy link
Contributor

@heplesser heplesser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot @hakonsbm!

Kernel automation moved this from PRs pending approval to PRs approved Nov 11, 2021
@heplesser heplesser merged commit a8806dd into nest:master Nov 11, 2021
Kernel automation moved this from PRs approved to Done (PRs and issues) Nov 11, 2021
@hakonsbm hakonsbm deleted the MPI_local_positions branch November 11, 2021 07:44
@hakonsbm hakonsbm mentioned this pull request Mar 1, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@heplesser heplesser heplesser approved these changes

@stinebuu stinebuu stinebuu approved these changes

Assignees
No one assigned
Labels
I: No breaking change Previously written code will work as before, no one should note anything changing (aside the fix) S: Critical Needs to be addressed immediately T: Bug Wrong statements in the code or documentation
Projects
Kernel
  
Done
Milestone
NEST 3.2
Development

Successfully merging this pull request may close these issues.

Creation and storage of node positions is not distributed over MPI processes
3 participants
@hakonsbm @heplesser @stinebuu