Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tidy up SLI startup, especially opening of sli-init.sli #2183

Merged
merged 1 commit into from
Nov 12, 2021
Merged

Tidy up SLI startup, especially opening of sli-init.sli #2183

merged 1 commit into from
Nov 12, 2021

Conversation

heplesser
Copy link
Contributor

This PR tidies slistartup.[h,cc], removing unused code, renaming some variables and in particular making the check for the sli-init.sli file more robust by not only checking for its existence, but also for readability. This might address confusing problems observed by @steffengraber during container construction.

@heplesser heplesser added T: Bug Wrong statements in the code or documentation S: High Should be handled next I: No breaking change Previously written code will work as before, no one should note anything changing (aside the fix) labels Oct 9, 2021
@heplesser heplesser added this to PRs in progress in Kernel via automation Oct 9, 2021
gtrensch
gtrensch approved these changes Oct 14, 2021
View reviewed changes
Copy link
Contributor

@gtrensch gtrensch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution! Approved.

Kernel automation moved this from PRs in progress to PRs approved Oct 14, 2021
jougs
jougs approved these changes Nov 12, 2021
View reviewed changes
Copy link
Contributor

@jougs jougs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is indeed much cleaner.

@jougs jougs removed the request for review from terhorstd November 12, 2021 07:30
@heplesser heplesser merged commit 5453958 into nest:master Nov 12, 2021
Kernel automation moved this from PRs approved to Done (PRs and issues) Nov 12, 2021
@jougs jougs changed the title Tidy up SLI startup, especially opening of sli-init.sli. Tidy up SLI startup, especially opening of sli-init.sli Jan 21, 2022
@heplesser heplesser deleted the startup-cleanup branch April 20, 2022 11:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jougs jougs jougs approved these changes

@gtrensch gtrensch gtrensch approved these changes

Assignees
No one assigned
Labels
I: No breaking change Previously written code will work as before, no one should note anything changing (aside the fix) S: High Should be handled next T: Bug Wrong statements in the code or documentation
Projects
Kernel
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@heplesser @jougs @gtrensch