-
Notifications
You must be signed in to change notification settings - Fork 357
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Restructure CI pipeline configuration #2200
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this extensive cleanup. I've left some inline comments, but am mostly fine as is.
Co-authored-by: Jochen Martin Eppler <jougs@gmx.net>
Co-authored-by: Jochen Martin Eppler <jougs@gmx.net>
Co-authored-by: Jochen Martin Eppler <jougs@gmx.net>
…nest-simulator into refactor-static-code-analysis
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks again for this massive cleanup :-)
@terhorstd I just have this small comment on your reply. Can you please have a look? |
@pnbabu: could you please resolve the open discussions and indicate if you request further changes? Thanks! |
Update Github workflow with the following modifications
set -euo pipefail
to CI scripts to catch false negatives.Some preparatory modifications of the build scripts, notably:
extras/
to more meaningful locations:bin/
{extras,build_support}/*
Started cleaning up dependency management