Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restructure CI pipeline configuration #2200

Merged
merged 56 commits into from
Nov 29, 2021

Conversation

terhorstd
Copy link
Contributor

Update Github workflow with the following modifications

  • separate static code checks from build jobs
  • fix dependency management (a bit) due to wrongly interpreted syntax
  • add set -euo pipefail to CI scripts to catch false negatives.
  • register output logs as artifacts (visible on actions page)

Some preparatory modifications of the build scripts, notably:

  • sorting of files in extras/ to more meaningful locations:
    • created bin/
    • rename of many files {extras,build_support}/*
  • many cleanups of spurious whitespaces and unhandled (and unseen) undefined variables and conditions

Started cleaning up dependency management

  • renamed conda environment files to standard names
  • adapted documentation to new dependency handling

@jougs jougs added I: Internal API Changes were introduced in basic internal workings of the simulator that developers need to know S: Normal Handle this with default priority T: Maintenance Work to keep up the quality of the code and documentation. labels Nov 5, 2021
@jougs jougs added this to To do in Build system and CI via automation Nov 5, 2021
@jougs jougs added this to the NEST 3.2 milestone Nov 5, 2021
Copy link
Contributor

@jougs jougs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this extensive cleanup. I've left some inline comments, but am mostly fine as is.

.github/workflows/nestbuildmatrix.yml Outdated Show resolved Hide resolved
.github/workflows/nestbuildmatrix.yml Outdated Show resolved Hide resolved
.gitignore Outdated Show resolved Hide resolved
.gitignore Outdated Show resolved Hide resolved
environment.yml Show resolved Hide resolved
.github/workflows/nestbuildmatrix.yml Outdated Show resolved Hide resolved
.github/workflows/nestbuildmatrix.yml Outdated Show resolved Hide resolved
.github/workflows/nestbuildmatrix.yml Outdated Show resolved Hide resolved
.github/workflows/nestbuildmatrix.yml Outdated Show resolved Hide resolved
.github/workflows/nestbuildmatrix.yml Show resolved Hide resolved
.github/workflows/nestbuildmatrix.yml Show resolved Hide resolved
.github/workflows/nestbuildmatrix.yml Outdated Show resolved Hide resolved
.github/workflows/nestbuildmatrix.yml Outdated Show resolved Hide resolved
doc/userdoc/nest_server.rst Show resolved Hide resolved
terhorstd and others added 6 commits November 11, 2021 10:11
Co-authored-by: Jochen Martin Eppler <jougs@gmx.net>
Co-authored-by: Jochen Martin Eppler <jougs@gmx.net>
Co-authored-by: Jochen Martin Eppler <jougs@gmx.net>
…nest-simulator into refactor-static-code-analysis
Copy link
Contributor

@jougs jougs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks again for this massive cleanup :-)

environment.yml Show resolved Hide resolved
@pnbabu
Copy link
Contributor

pnbabu commented Nov 15, 2021

@terhorstd I just have this small comment on your reply. Can you please have a look?

@jougs
Copy link
Contributor

jougs commented Nov 18, 2021

@pnbabu: could you please resolve the open discussions and indicate if you request further changes?
@terhorstd: could you please resolve the conflict that popped up?

Thanks!

@terhorstd terhorstd changed the title Refactor static code analysis Restructure CI pipeline configuration Nov 29, 2021
@jougs jougs merged commit 0915e6b into nest:master Nov 29, 2021
Build system and CI automation moved this from To do to Done Nov 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
I: Internal API Changes were introduced in basic internal workings of the simulator that developers need to know S: Normal Handle this with default priority T: Maintenance Work to keep up the quality of the code and documentation.
Projects
Development

Successfully merging this pull request may close these issues.

None yet

3 participants