Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update outdated code snippets in documentation #2205

Merged
merged 1 commit into from
Nov 12, 2021
Merged

Update outdated code snippets in documentation #2205

merged 1 commit into from
Nov 12, 2021

Conversation

stinebuu
Copy link
Contributor

@stinebuu stinebuu commented Nov 9, 2021

I noticed some code snippets in the guides that are outdated.

@stinebuu stinebuu added S: Normal Handle this with default priority T: Maintenance Work to keep up the quality of the code and documentation. I: No breaking change Previously written code will work as before, no one should note anything changing (aside the fix) labels Nov 9, 2021
@stinebuu stinebuu added this to In progress in Documentation via automation Nov 9, 2021
jougs
jougs approved these changes Nov 12, 2021
View reviewed changes
Copy link
Contributor

@jougs jougs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Merging without second review, as this "only" concerns documentation.

Documentation automation moved this from In progress to Review Nov 12, 2021
@jougs jougs added this to the NEST 3.2 milestone Nov 12, 2021
@jougs jougs merged commit 186e5b3 into nest:master Nov 12, 2021
Documentation automation moved this from Review to Done Nov 12, 2021
@stinebuu stinebuu deleted the update_doc branch January 17, 2022 10:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jougs jougs jougs approved these changes

@jessica-mitchell jessica-mitchell Awaiting requested review from jessica-mitchell

@hakonsbm hakonsbm Awaiting requested review from hakonsbm

Assignees
No one assigned
Labels
I: No breaking change Previously written code will work as before, no one should note anything changing (aside the fix) S: Normal Handle this with default priority T: Maintenance Work to keep up the quality of the code and documentation.
Projects
Documentation
  
Done
Milestone
NEST 3.2
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@stinebuu @jougs