Add additional reference to Izhikevich model documentation #2216
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jessica-mitchell
added
I: No breaking change
clinssen
reviewed
Nov 29, 2021
There was a problem hiding this comment.
Would move to reject (sorry!)
The paragraph about the numerics is redundant with the preceding paragraph, that already covers these issues, and how these are addressed in the NEST model. The comment about STDP does not seem relevant to this model as it is a neuron model without any direct relationship to synaptic plasticity.
Co-authored-by: Jochen Martin Eppler <j.eppler@fz-juelich.de>
clinssen
approved these changes
Dec 6, 2021
jougs
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds some text to the model doc mentioning differences between NEST and the original author's model. Includes reference to Pauli et al. paper. 2018.
Not sure if this needs a lot more detail in the documentation or if link suffices.