Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unused parameter from STDP unit test #2222

Merged
merged 1 commit into from
Nov 29, 2021
Merged

Remove unused parameter from STDP unit test #2222

merged 1 commit into from
Nov 29, 2021

Conversation

clinssen
Copy link
Contributor

No description provided.

@jougs jougs self-requested a review November 29, 2021 10:05
@jougs jougs added I: No breaking change Previously written code will work as before, no one should note anything changing (aside the fix) T: Maintenance Work to keep up the quality of the code and documentation. labels Nov 29, 2021
@jougs jougs added this to In progress in Automated testing via automation Nov 29, 2021
@jougs jougs added this to the NEST 3.2 milestone Nov 29, 2021
jougs
jougs approved these changes Nov 29, 2021
View reviewed changes
Copy link
Contributor

@jougs jougs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Taking CI as second reviewer and merging immediately.

Automated testing automation moved this from In progress to Reviewer approved Nov 29, 2021
@jougs jougs merged commit 7d5d660 into nest:master Nov 29, 2021
Automated testing automation moved this from Reviewer approved to Done Nov 29, 2021
@terhorstd terhorstd added the S: Normal Handle this with default priority label Jan 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jougs jougs jougs approved these changes

Assignees

@clinssen clinssen

Labels
I: No breaking change Previously written code will work as before, no one should note anything changing (aside the fix) S: Normal Handle this with default priority T: Maintenance Work to keep up the quality of the code and documentation.
Projects
No open projects
Automated testing
  
Done
Milestone
NEST 3.2
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@clinssen @jougs @terhorstd