Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump sphinx version to >=4.0.2 to remove jinja<3 requirement #2228

Merged
merged 3 commits into from
Dec 10, 2021

Conversation

hakonsbm
Copy link
Contributor

@hakonsbm hakonsbm commented Dec 6, 2021

Also moving sphinx-tabs to be pip installed because the conda-forge version currently only supports sphinx <= 3. Fixes #2041.

sphinx-tabs moved to be pip installed because conda-forge version currently only supports sphinx <= 3.
@hakonsbm hakonsbm added S: Normal Handle this with default priority T: Maintenance Work to keep up the quality of the code and documentation. I: No breaking change Previously written code will work as before, no one should note anything changing (aside the fix) labels Dec 6, 2021
@hakonsbm hakonsbm added this to In progress in Documentation via automation Dec 6, 2021
@jessica-mitchell
Copy link
Contributor

@hakonsbm Could you also update doc/requirements.txt thanks!

Copy link
Contributor

@jessica-mitchell jessica-mitchell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks, this works for me!

Documentation automation moved this from In progress to Review Dec 9, 2021
@heplesser
Copy link
Contributor

Merging this one based on single review.

@heplesser heplesser merged commit 8315aec into nest:master Dec 10, 2021
Documentation automation moved this from Review to Done Dec 10, 2021
@hakonsbm hakonsbm deleted the conda_jinja_sphinx_issue branch December 14, 2021 07:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
I: No breaking change Previously written code will work as before, no one should note anything changing (aside the fix) S: Normal Handle this with default priority T: Maintenance Work to keep up the quality of the code and documentation.
Projects
Documentation
  
Done
Development

Successfully merging this pull request may close these issues.

Update dependencies when Sphinx 4.1.0 is released
3 participants