Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Format error messages in jonke_synapse and stdp_dopamine_synapse #2232

Merged
merged 2 commits into from
Dec 15, 2021

Conversation

stinebuu
Copy link
Contributor

@stinebuu stinebuu commented Dec 7, 2021

This PR fixes #2044.

As far as I can see, the parameters still need to be set with SetDefaults() or CopyModel(), because they are part of their own class containing the common properties (JonkeCommonProperties and STDPDopaCommonProperties). This PR thus only change the formatting of the error messages.

@stinebuu stinebuu added S: Normal Handle this with default priority T: Maintenance Work to keep up the quality of the code and documentation. I: No breaking change Previously written code will work as before, no one should note anything changing (aside the fix) labels Dec 7, 2021
@stinebuu stinebuu added this to To do in Models via automation Dec 7, 2021
@heplesser
Copy link
Contributor

Since this is a minimal formatting change, I merge without second review.

@heplesser heplesser merged commit c566adb into nest:master Dec 15, 2021
@stinebuu stinebuu deleted the check_params branch December 15, 2021 13:01
@clinssen clinssen moved this from To do to Done in Models Nov 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
I: No breaking change Previously written code will work as before, no one should note anything changing (aside the fix) S: Normal Handle this with default priority T: Maintenance Work to keep up the quality of the code and documentation.
Projects
Models
  
Done
Development

Successfully merging this pull request may close these issues.

Check if synapse parameters can be set during connection
2 participants