-
Notifications
You must be signed in to change notification settings - Fork 357
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enhance and clean up model documentation #2246
Conversation
@terhorstd, @jessica-mitchell: friendly ping! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jougs looks good, I just made some suggestions to mainly adding double back ticks in a few places
Co-authored-by: jessica-mitchell <mitchell20j@gmail.com>
@jessica-mitchell: I have applied most of your suggestions and have two questions for the as-of-yet unapplied ones (mostly regarding
|
Ah yes, that would make more sense, I just wasn't thinking about it
Yes there is a way to do this but not implemented in any way yet;i think this could be something we look at in a future PR though |
Co-authored-by: jessica-mitchell <mitchell20j@gmail.com>
@jessica-mitchell: I've addressed all remaining issues as you suggested. You get to decide if you actually find the second review necessary for this one, or if your approval would be sufficient to merge. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jougs thanks! looks good to me and considering these are basically formatting issues, I'd say one review is enough
This PR addresses the remaining open action items and thereby fixes #1620.