Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix path to connection diagram for HPC benchmark example #2248

Merged
merged 1 commit into from
Dec 20, 2021
Merged

Fix path to connection diagram for HPC benchmark example #2248

merged 1 commit into from
Dec 20, 2021

Conversation

steffengraber
Copy link
Contributor

The used path works only in the local preview of the HTML files.
The path inside the generated .rst file must point to the image in the directory userdoc/examples, only then it will be moved to the correct path by make html.

@jarsi
Copy link
Contributor

jarsi commented Dec 17, 2021

Thank you @steffengraber for working out the path magic. It indeed fixes the appearance of the figure, so it could be merged.

@stinebuu stinebuu added I: No breaking change Previously written code will work as before, no one should note anything changing (aside the fix) S: Normal Handle this with default priority T: Maintenance Work to keep up the quality of the code and documentation. labels Dec 17, 2021
@stinebuu stinebuu added this to In progress in Documentation via automation Dec 17, 2021
@jougs jougs changed the title Appearance of image fixed Fix path to connection diagram for HPC benchmark example Dec 20, 2021
@jougs jougs merged commit 06f9276 into nest:master Dec 20, 2021
Documentation automation moved this from In progress to Done Dec 20, 2021
@steffengraber steffengraber deleted the fix-benchmark-image branch September 6, 2023 05:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jarsi jarsi Awaiting requested review from jarsi

Assignees
No one assigned
Labels
I: No breaking change Previously written code will work as before, no one should note anything changing (aside the fix) S: Normal Handle this with default priority T: Maintenance Work to keep up the quality of the code and documentation.
Projects
Documentation
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@steffengraber @jarsi @jougs @stinebuu