Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make plot_weight_matrices.py run #2262

Merged
merged 1 commit into from
Feb 1, 2022
Merged

Make plot_weight_matrices.py run #2262

merged 1 commit into from
Feb 1, 2022

Conversation

stinebuu
Copy link
Contributor

This PR fixes #2138.

@stinebuu stinebuu added S: Normal Handle this with default priority T: Maintenance Work to keep up the quality of the code and documentation. I: No breaking change Previously written code will work as before, no one should note anything changing (aside the fix) labels Jan 14, 2022
@stinebuu stinebuu added this to In progress in PyNEST via automation Jan 14, 2022
@stinebuu stinebuu changed the title Make plot_weight_matrices.py runnable Make plot_weight_matrices.py run Jan 14, 2022
@stinebuu stinebuu moved this from In progress to Review in PyNEST Jan 28, 2022
hakonsbm
hakonsbm approved these changes Jan 31, 2022
View reviewed changes
Copy link
Contributor

@hakonsbm hakonsbm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works and looks good 👍

pnbabu
pnbabu approved these changes Feb 1, 2022
View reviewed changes
Copy link
Contributor

@pnbabu pnbabu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@hakonsbm hakonsbm merged commit cc15d05 into nest:master Feb 1, 2022
PyNEST automation moved this from Review to Done Feb 1, 2022
@stinebuu stinebuu deleted the fix_plot_weight_matrices branch February 1, 2022 12:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hakonsbm hakonsbm hakonsbm approved these changes

@pnbabu pnbabu pnbabu approved these changes

Assignees
No one assigned
Labels
I: No breaking change Previously written code will work as before, no one should note anything changing (aside the fix) S: Normal Handle this with default priority T: Maintenance Work to keep up the quality of the code and documentation.
Projects
PyNEST
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

plot_weight_matrices.py should be rewritten
3 participants
@stinebuu @hakonsbm @pnbabu