Fix naming clash in Clopath plasticity neurons #2263
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clinssen
added
T: Bug
|
@jstapmanns Could you review this renaming? I will open a follow-up issue concerning documentation. |
jstapmanns
approved these changes
Mar 7, 2022
There was a problem hiding this comment.
Thank you very much @clinssen! The proposed changes look good to me.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The name "tau_minus" is used by the ArchivingNode for the postsynaptic trace time constant. The same name was being used by aeif_psc_delta_clopath and hh_psc_alpha_clopath for the time constant of another variable,
u_minusin the Clopath synapse context.This PR resolves the issue by renaming the latter to
tau_u_bar_minus(and makes related changes for consistency).With thanks to Jette Oberländer for reporting this issue.