Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up OpenMP pragmas #2273

Merged
merged 14 commits into from
Jan 21, 2022
Merged

Clean up OpenMP pragmas #2273

merged 14 commits into from
Jan 21, 2022

Conversation

jougs
Copy link
Contributor

@jougs jougs commented Jan 20, 2022 •
edited

This PR removes empty loops in case of single threading and generally cleans up and comments the OpenMP pragmas. On the way, i took the liberty to clean up some deprecation warnings that originated from the Python tests.

@jougs jougs added S: Normal Handle this with default priority T: Maintenance Work to keep up the quality of the code and documentation. I: Internal API Changes were introduced in basic internal workings of the simulator that developers need to know labels Jan 20, 2022
@jougs jougs added this to PRs in progress in Kernel via automation Jan 20, 2022
@jougs jougs self-assigned this Jan 20, 2022
heplesser
heplesser approved these changes Jan 20, 2022
View reviewed changes
Copy link
Contributor

@heplesser heplesser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for cleaning up!

Kernel automation moved this from PRs in progress to PRs approved Jan 20, 2022
@jougs jougs mentioned this pull request Jan 20, 2022
Closed
@jougs jougs requested review from hakonsbm and removed request for terhorstd January 20, 2022 18:51
hakonsbm
hakonsbm suggested changes Jan 21, 2022
View reviewed changes
Copy link
Contributor

@hakonsbm hakonsbm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I have just a tiny suggestion.

testsuite/pytests/test_events.py Outdated Show resolved Hide resolved
Kernel automation moved this from PRs approved to PRs pending approval Jan 21, 2022
@jougs @hakonsbm
Update testsuite/pytests/test_events.py
89204b6 
Co-authored-by: Håkon Bakke Mørk <hakon.mork@nmbu.no>
Kernel automation moved this from PRs pending approval to PRs approved Jan 21, 2022
@hakonsbm hakonsbm merged commit 80d531f into nest:master Jan 21, 2022
Kernel automation moved this from PRs approved to Done (PRs and issues) Jan 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@heplesser heplesser heplesser approved these changes

@hakonsbm hakonsbm hakonsbm approved these changes

Assignees

@jougs jougs

Labels
I: Internal API Changes were introduced in basic internal workings of the simulator that developers need to know S: Normal Handle this with default priority T: Maintenance Work to keep up the quality of the code and documentation.
Projects
Kernel
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jougs @heplesser @hakonsbm