Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix version warning #2274

Merged
merged 1 commit into from
Jan 21, 2022
Merged

Conversation

steffengraber
Copy link
Contributor

@steffengraber steffengraber commented Jan 21, 2022

On Read the docs the version specified as "latest" is in some places ambiguously pointing to "latest release" and "latest on main branch". This leads to some confusion when referring to "latest". Removing this from the code and relying only on the "show version warning" option on readthedocs, we can enable and disable this warning from the outside, without having a potentially wrong warning in a release that is not removable.

@terhorstd terhorstd self-requested a review January 21, 2022 15:20
@terhorstd terhorstd added S: Normal Handle this with default priority T: Maintenance Work to keep up the quality of the code and documentation. labels Jan 21, 2022
@terhorstd terhorstd added this to In progress in Documentation via automation Jan 21, 2022
@terhorstd terhorstd merged commit 998c74d into nest:master Jan 21, 2022
Documentation automation moved this from In progress to Done Jan 21, 2022
Copy link
Contributor

@terhorstd terhorstd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S: Normal Handle this with default priority T: Maintenance Work to keep up the quality of the code and documentation.
Projects
Documentation
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants