Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix search field on readthedocs #2297

Merged
merged 3 commits into from
Feb 17, 2022
Merged

Fix search field on readthedocs #2297

merged 3 commits into from
Feb 17, 2022

Conversation

steffengraber
Copy link
Contributor

@steffengraber steffengraber commented Feb 16, 2022 •
edited by jessica-mitchell

For NEST version 3.2 the search field on readthedocs do not work. The issue is in the sphinx plugin HoverXTooltip. An outdated version of jquery is called there.
This PR fixes this bug and at the same time updates the scripts needed for the documentation website.

Fixes #2292 .

jessica-mitchell
jessica-mitchell approved these changes Feb 17, 2022
View reviewed changes
Copy link
Contributor

@jessica-mitchell jessica-mitchell left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested this, and everything seems to work fine. The orange background on the hover tooltip is gone but that's a very minor issue and it looks fine as is.

@jessica-mitchell jessica-mitchell added this to In progress in Documentation via automation Feb 17, 2022
@jessica-mitchell jessica-mitchell added I: No breaking change Previously written code will work as before, no one should note anything changing (aside the fix) T: Maintenance Work to keep up the quality of the code and documentation. S: High Should be handled next labels Feb 17, 2022
@jessica-mitchell jessica-mitchell changed the title Search field on readthedocs fixed Fix search field on readthedocs Feb 17, 2022
@jessica-mitchell jessica-mitchell moved this from In progress to Review in Documentation Feb 17, 2022
@heplesser
Copy link
Contributor

Since this relates to documentation mechanics, I merge based on a single review.

@heplesser heplesser merged commit df4d8b1 into nest:master Feb 17, 2022
Documentation automation moved this from Review to Done Feb 17, 2022
@steffengraber steffengraber deleted the fix-issue-2292 branch September 6, 2023 05:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jessica-mitchell jessica-mitchell jessica-mitchell approved these changes

Assignees
No one assigned
Labels
I: No breaking change Previously written code will work as before, no one should note anything changing (aside the fix) S: High Should be handled next T: Maintenance Work to keep up the quality of the code and documentation.
Projects
Documentation
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Search is broken on ReadTheDocs
3 participants
@steffengraber @heplesser @jessica-mitchell