Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove CMake options and other references to BlueGene and K-computer #2306

Merged
merged 6 commits into from
Mar 7, 2022
Merged

Remove CMake options and other references to BlueGene and K-computer #2306

merged 6 commits into from
Mar 7, 2022

Conversation

stinebuu
Copy link
Contributor

This fixes #2249

@stinebuu stinebuu added S: Normal Handle this with default priority T: Maintenance Work to keep up the quality of the code and documentation. I: No breaking change Previously written code will work as before, no one should note anything changing (aside the fix) labels Feb 22, 2022
@stinebuu stinebuu added this to To do in Installation via automation Feb 22, 2022
heplesser
heplesser requested changes Feb 28, 2022
View reviewed changes
Copy link
Contributor

@heplesser heplesser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this PR. Please see my comments below. One general question: Is the Fujitsu-Cmake file relevant for Fugaku?

cmake/ProcessOptions.cmake Outdated Show resolved Hide resolved
nest/neststartup.cpp Outdated Show resolved Hide resolved
nest/neststartup.cpp Show resolved Hide resolved
nestkernel/mpi_manager_impl.h Outdated Show resolved Hide resolved
Installation automation moved this from To do to Review Feb 28, 2022
stinebuu and others added 2 commits March 1, 2022 09:09
@stinebuu @heplesser
Apply suggestions from code review
345b2b0 
Co-authored-by: Hans Ekkehard Plesser <hans.ekkehard.plesser@nmbu.no>
@stinebuu
Add back code that should not have been removed
c3ebf65
@stinebuu
Copy link
Contributor Author

stinebuu commented Mar 1, 2022

@heplesser Thanks for your review, I have updated the PR now.

Concerning the Fujitsu-Cmake file, I don't think it is needed for Fugako, but I will ask people with more expertise here just in case.

@heplesser
Copy link
Contributor

@heplesser Thanks for your review, I have updated the PR now.

Concerning the Fujitsu-Cmake file, I don't think it is needed for Fugako, but I will ask people with more expertise here just in case.

I think that for this PR, we should just remove fujitsu-sparc64. We may then if needed add instruction for Fugaku in a separate PR.

gtrensch
gtrensch approved these changes Mar 7, 2022
View reviewed changes
Copy link
Contributor

@gtrensch gtrensch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this pull request. 👍 Approved.

@gtrensch gtrensch mentioned this pull request Mar 7, 2022
Closed
@gtrensch gtrensch changed the title Remove c-make options and other references to BlueGene and K-computer Remove CMake options and other references to BlueGene and K-computer Mar 7, 2022
@gtrensch gtrensch merged commit 5bf12a6 into nest:master Mar 7, 2022
Installation automation moved this from Review to Done Mar 7, 2022
@stinebuu stinebuu deleted the remove_old_machines branch March 7, 2022 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@heplesser heplesser heplesser approved these changes

@gtrensch gtrensch gtrensch approved these changes

Assignees
No one assigned
Labels
I: No breaking change Previously written code will work as before, no one should note anything changing (aside the fix) S: Normal Handle this with default priority T: Maintenance Work to keep up the quality of the code and documentation.
Projects
Installation
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

C-make options and other references to Bluegene and K-computer still exists
3 participants
@stinebuu @heplesser @gtrensch