-
Notifications
You must be signed in to change notification settings - Fork 358
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use updateValue< long >
instead of update_value_int
in quantal_stp_synapse
#2307
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
:-)
Co-authored-by: clinssen <c.linssen@fz-juelich.de>
update_value_int
from quantal_stp_synapse.cpp
updateValue< long >
instead of update_value_int
in quantal_stp_synapse
One question: Does |
@jougs Good point. An error is now thrown if we provide a double. It is quite easy to fix by adding a check in the function of nest-simulator/sli/tokenutils.cc Lines 41 to 50 in 66269a2
|
I don't understand why this automatic cast is necessary; it could even be dangerous due to loss of precision. The underlying data type in class The only actual danger is mixing an |
Argh! You're right, @clinssen. I was thinking the wrong way around all the time. This function updates a C++ variable of type |
I will convert back to 0434725 😉 |
e92b16a
to
0434725
Compare
This PR fixes #2049