Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up and add links for compartmental model docs #2313

Merged
merged 4 commits into from
Mar 7, 2022

Conversation

jessica-mitchell
Copy link
Contributor

This PR fixes a few formatting issues with the model documentation and adds a link on Read the Docs for the PyNEST examples.

@jessica-mitchell jessica-mitchell changed the title Clean up an dadd links for compartmental model docs Clean up and add links for compartmental model docs Feb 25, 2022
@jessica-mitchell jessica-mitchell added I: No breaking change Previously written code will work as before, no one should note anything changing (aside the fix) S: High Should be handled next T: Maintenance Work to keep up the quality of the code and documentation. labels Feb 25, 2022
@jessica-mitchell jessica-mitchell added this to In progress in Documentation via automation Feb 25, 2022
models/cm_default.h Outdated Show resolved Hide resolved
models/cm_default.h Outdated Show resolved Hide resolved
models/cm_default.h Outdated Show resolved Hide resolved
Documentation automation moved this from In progress to Review Feb 28, 2022
Co-authored-by: clinssen <c.linssen@fz-juelich.de>
Copy link
Contributor

@jougs jougs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks mostly good to me.

models/cm_default.h Outdated Show resolved Hide resolved
models/cm_default.h Outdated Show resolved Hide resolved
models/cm_default.h Outdated Show resolved Hide resolved
Co-authored-by: Jochen Martin Eppler <jougs@gmx.net>
Copy link
Contributor

@jougs jougs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@clinssen clinssen merged commit 69f0ed4 into nest:master Mar 7, 2022
Documentation automation moved this from Review to Done Mar 7, 2022
@jessica-mitchell jessica-mitchell deleted the fix-cm-docs branch April 17, 2024 18:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
I: No breaking change Previously written code will work as before, no one should note anything changing (aside the fix) S: High Should be handled next T: Maintenance Work to keep up the quality of the code and documentation.
Projects
Documentation
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants