Add accuracy tests for precise models lacking them #2314
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
heplesser
changed the title
heplesser
approved these changes
Mar 7, 2022
| S_.y2_ = | ||
| V_.P20_ * ( P_.I_e_ + S_.y0_ ) + V_.P21_ex_ * S_.y1_ex_ + V_.P21_in_ * S_.y1_in_ + S_.y2_ * V_.exp_tau_m_; | ||
| // If we use S_.y2_ * std::exp( -V_.h_ms_ / P_.tau_m_ ) instead of | ||
| // V_.expm1_tau_m_ * S_.y2_ + S_.y2_ here, the accuracy decrease, |
There was a problem hiding this comment.
Suggested change
| // V_.expm1_tau_m_ * S_.y2_ + S_.y2_ here, the accuracy decrease, | |
| // V_.expm1_tau_m_ * S_.y2_ + S_.y2_ here, the accuracy decreases, |
| @@ -367,8 +366,11 @@ nest::iaf_psc_exp_ps_lossless::update( const Time& origin, const long from, cons | |||
| // update membrane potential | |||
| if ( not S_.is_refractory_ ) | |||
| { | |||
| // If we use S_.y2_ * std::exp( -V_.h_ms_ / P_.tau_m_ ) instead of | |||
| // V_.expm1_tau_m_ * S_.y2_ + S_.y2_ here, the accuracy decrease, | |||
There was a problem hiding this comment.
Suggested change
| // V_.expm1_tau_m_ * S_.y2_ + S_.y2_ here, the accuracy decrease, | |
| // V_.expm1_tau_m_ * S_.y2_ + S_.y2_ here, the accuracy decreases, |
clinssen
reviewed
Mar 7, 2022
| } repeat | ||
| endl | ||
|
|
||
| exch | ||
| { | ||
| { exch 24 setw exch <- ( ) <- } forall endl | ||
| { exch 20 setw exch <- ( ) <- } forall endl |
There was a problem hiding this comment.
The column width for tabular output.
terhorstd
added
S: Normal
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With @jougs PR #2294 I remembered that I started working on issue #1493, extending accuracy testing for precise models, a long time ago. This PR fixes the first part of that issue.
I have added
iaf_psc_exp_psandiaf_psc_exp_ps_losslesstotest_iaf_ps_dc_accuracy.sliandtest_iaf_ps_dc_t_accuracy.sli. To make the test run, I had to update the models to useexpm1 + 1instead ofexpto increase accuracy.It also seemed to me that the setting of
t_spikeforiaf_psc_exp_ps_losslesswas wrong, so I have updated it to fit with the other models.When it comes to the second part of issue #1493:
I am not quite sure how to fix this, but I wanted to already create this PR for the first part of the issue, as it is good to also test the accuracy of
iaf_psc_exp_psandiaf_psc_exp_ps_lossless.