Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disallow specifying lists of synapse models #2317

Merged
merged 6 commits into from
Mar 8, 2022
Merged

Disallow specifying lists of synapse models #2317

merged 6 commits into from
Mar 8, 2022

Conversation

hakonsbm
Copy link
Contributor

Limits synapse_model to be a string, and fixes a typo in pynestkernel.pyx which lead to confusing error messages. Fixes #2301.

@hakonsbm hakonsbm added S: Normal Handle this with default priority T: Maintenance Work to keep up the quality of the code and documentation. I: No breaking change Previously written code will work as before, no one should note anything changing (aside the fix) labels Feb 28, 2022
@hakonsbm hakonsbm added this to In progress in PyNEST via automation Feb 28, 2022
@hakonsbm
Adjusted check of syn_spec
2329bf2 
for the case where syn_spec is a CollocatedSynapses object
@jougs jougs requested a review from clinssen March 4, 2022 15:40
jougs
jougs approved these changes Mar 7, 2022
View reviewed changes
Copy link
Contributor

@jougs jougs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for addressing this so quickly!

PyNEST automation moved this from In progress to Review Mar 7, 2022
clinssen
clinssen requested changes Mar 7, 2022
View reviewed changes
pynest/nest/lib/hl_api_connection_helpers.py Outdated Show resolved Hide resolved
pynest/pynestkernel.pyx Show resolved Hide resolved
pynest/pynestkernel.pyx Show resolved Hide resolved
@hakonsbm hakonsbm requested a review from clinssen March 8, 2022 09:12
clinssen
clinssen approved these changes Mar 8, 2022
View reviewed changes
Copy link
Contributor

@clinssen clinssen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cheers!

@heplesser heplesser merged commit 9c13f71 into nest:master Mar 8, 2022
PyNEST automation moved this from Review to Done Mar 8, 2022
@hakonsbm hakonsbm deleted the synapse_model_list branch August 1, 2022 07:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jougs jougs jougs approved these changes

@clinssen clinssen clinssen approved these changes

Assignees
No one assigned
Labels
I: No breaking change Previously written code will work as before, no one should note anything changing (aside the fix) S: Normal Handle this with default priority T: Maintenance Work to keep up the quality of the code and documentation.
Projects
PyNEST
Status: Done
PyNEST
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Exception when specying synapse models as list in Connect()
4 participants
@hakonsbm @jougs @clinssen @heplesser