Make the C++ standard configurable #2319
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hakonsbm
added
T: Enhancement
jougs
reviewed
Mar 1, 2022
heplesser
requested changes
Mar 1, 2022
There was a problem hiding this comment.
Looks fine, just one little suggestion for documentation.
And please also add documentation for the option in the "Generic build configuration" section of https://github.com/nest/nest-simulator/blob/master/doc/userdoc/installation/cmake_options.rst
Co-authored-by: Hans Ekkehard Plesser <hans.ekkehard.plesser@nmbu.no>
heplesser
reviewed
Mar 1, 2022
| @@ -120,6 +120,8 @@ Generic build configuration | |||
| | ``-Dwith-intel-compiler-flags=[OFF|<list;of;flags>]``| User defined flags for the Intel compiler | | |||
| | | [default='-fp-model strict']. Separate multiple flags by ';'. | | |||
| +------------------------------------------------------+------------------------------------------------------------------+ | |||
| | ``-Dwith-cpp-std=[OFF|<C++ standard>]`` | C++ standard to use for compilation [default='c++11']. | | |||
There was a problem hiding this comment.
Does -Dwith-cpp-std=OFF actually work and result in the default value?
There was a problem hiding this comment.
It does, OFF would just mean the default value. But because it's a bit confusing I have corrected the CMake variable now.
jougs
approved these changes
Mar 1, 2022
heplesser
approved these changes
Mar 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The C++ standard can now be specified in CMake configuration with
-Dwith-std=<C++ standard>. Default isC++11. Fixes #2259.