Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix stdout and status of nest-server #2325

Merged
merged 3 commits into from
May 12, 2022
Merged

Fix stdout and status of nest-server #2325

merged 3 commits into from
May 12, 2022

Conversation

babsey
Copy link
Contributor

@babsey babsey commented Mar 4, 2022

This PR fixes several bugs:

  • correct usage for nest-server start.
  • correct display for nest-server status.
  • add environment for logfile path.

@clinssen clinssen requested review from terhorstd and jougs March 7, 2022 10:25
@clinssen clinssen added this to PRs in progress in Kernel via automation Mar 7, 2022
@clinssen clinssen added I: User Interface Users may need to change their code due to changes in function calls S: Normal Handle this with default priority T: Maintenance Work to keep up the quality of the code and documentation. labels Mar 7, 2022
@babsey
Copy link
Contributor Author

babsey commented Mar 15, 2022

Friendly ping. I am hoping it will be merged for 3.3 release.

The current state of nest-server command might be unclean
and thus I do not guarantee its full operation working.

terhorstd
terhorstd reviewed Mar 15, 2022
View reviewed changes
Copy link
Contributor

@terhorstd terhorstd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks all like rather small changes, which are fine with me. One question though…

bin/nest-server Outdated Show resolved Hide resolved
jougs
jougs approved these changes Mar 17, 2022
View reviewed changes
Copy link
Contributor

@jougs jougs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Kernel automation moved this from PRs in progress to PRs approved Mar 17, 2022
@babsey
Copy link
Contributor Author

babsey commented Apr 6, 2022

Friendly ping.

terhorstd
terhorstd approved these changes May 12, 2022
View reviewed changes
Copy link
Contributor

@terhorstd terhorstd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Thanks!

@terhorstd terhorstd merged commit c4250d6 into nest:master May 12, 2022
Kernel automation moved this from PRs approved to Done (PRs and issues) May 12, 2022
@babsey babsey deleted the nest-server branch May 15, 2022 11:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jougs jougs jougs approved these changes

@terhorstd terhorstd terhorstd approved these changes

Assignees
No one assigned
Labels
I: User Interface Users may need to change their code due to changes in function calls S: Normal Handle this with default priority T: Maintenance Work to keep up the quality of the code and documentation.
Projects
Kernel
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@babsey @jougs @terhorstd @clinssen