Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Explain parrot neurons and clean up of NEST setup in Potjans_2014 documentation #2327

Merged
merged 3 commits into from
Mar 14, 2022
Merged

Explain parrot neurons and clean up of NEST setup in Potjans_2014 documentation #2327

merged 3 commits into from
Mar 14, 2022

Conversation

jhnnsnk
Copy link
Contributor

@jhnnsnk jhnnsnk commented Mar 7, 2022

This small PR improves the Potjans_2014 example in two places:

  1. It briefly documents why parrot_neurons are used for the thalamic population.
  2. It cleans up the initialization of the NEST kernel according to the new syntax.

@heplesser heplesser added I: No breaking change Previously written code will work as before, no one should note anything changing (aside the fix) S: Normal Handle this with default priority T: Maintenance Work to keep up the quality of the code and documentation. labels Mar 7, 2022
@heplesser heplesser added this to In progress in Documentation via automation Mar 7, 2022
jessica-mitchell
jessica-mitchell approved these changes Mar 9, 2022
View reviewed changes
Copy link
Contributor

@jessica-mitchell jessica-mitchell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! thanks

Documentation automation moved this from In progress to Review Mar 9, 2022
@terhorstd terhorstd changed the title Potjans_2014: Explain parrot neurons and clean up of NEST setup Explain parrot neurons and clean up of NEST setup in Potjans_2014 documentation Mar 14, 2022
@terhorstd terhorstd merged commit d8d6a07 into nest:master Mar 14, 2022
Documentation automation moved this from Review to Done Mar 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@heplesser heplesser heplesser approved these changes

@jessica-mitchell jessica-mitchell jessica-mitchell approved these changes

Assignees
No one assigned
Labels
I: No breaking change Previously written code will work as before, no one should note anything changing (aside the fix) S: Normal Handle this with default priority T: Maintenance Work to keep up the quality of the code and documentation.
Projects
Documentation
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@jhnnsnk @heplesser @jessica-mitchell @terhorstd