Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove installation of python2-dev from CI setup. #2329

Merged
merged 1 commit into from
Mar 11, 2022
Merged

Remove installation of python2-dev from CI setup. #2329

merged 1 commit into from
Mar 11, 2022

Conversation

heplesser
Copy link
Contributor

This PR removes installation of python2-dev from nestbuildmatrix.yml.

@heplesser heplesser added S: Normal Handle this with default priority T: Maintenance Work to keep up the quality of the code and documentation. I: No breaking change Previously written code will work as before, no one should note anything changing (aside the fix) labels Mar 7, 2022
@heplesser heplesser added this to In progress in Automated testing via automation Mar 7, 2022
lekshmideepu
lekshmideepu approved these changes Mar 9, 2022
View reviewed changes
Copy link
Contributor

@lekshmideepu lekshmideepu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! That makes sense.

Automated testing automation moved this from In progress to Reviewer approved Mar 9, 2022
jougs
jougs approved these changes Mar 11, 2022
View reviewed changes
Copy link
Contributor

@jougs jougs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

@jougs jougs removed the request for review from gtrensch March 11, 2022 10:09
@jougs jougs merged commit 6565ce1 into nest:master Mar 11, 2022
Automated testing automation moved this from Reviewer approved to Done Mar 11, 2022
@heplesser heplesser deleted the remove-python2-from-ci-scripts branch April 20, 2022 11:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jougs jougs jougs approved these changes

@lekshmideepu lekshmideepu lekshmideepu approved these changes

Assignees
No one assigned
Labels
I: No breaking change Previously written code will work as before, no one should note anything changing (aside the fix) S: Normal Handle this with default priority T: Maintenance Work to keep up the quality of the code and documentation.
Projects
No open projects
Automated testing
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@heplesser @jougs @lekshmideepu