Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix condition in bash script in case of non-existent variable #2331

Merged
merged 2 commits into from
Mar 15, 2022
Merged

Fix condition in bash script in case of non-existent variable #2331

merged 2 commits into from
Mar 15, 2022

Conversation

clinssen
Copy link
Contributor

@clinssen clinssen commented Mar 8, 2022

Fixes #2330.

@clinssen clinssen added T: Bug Wrong statements in the code or documentation S: Normal Handle this with default priority I: No breaking change Previously written code will work as before, no one should note anything changing (aside the fix) S: High Should be handled next T: Maintenance Work to keep up the quality of the code and documentation. and removed S: Normal Handle this with default priority T: Bug Wrong statements in the code or documentation S: High Should be handled next labels Mar 11, 2022
@clinssen clinssen requested review from terhorstd, gtrensch and jougs and removed request for gtrensch March 11, 2022 08:32
jougs
jougs approved these changes Mar 11, 2022
View reviewed changes
Copy link
Contributor

@jougs jougs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

testsuite/do_tests.sh Outdated Show resolved Hide resolved
@clinssen @jougs
fix syntax in testsuite/do_tests.sh
a471146 
Co-authored-by: Jochen Martin Eppler <jougs@gmx.net>
terhorstd
terhorstd approved these changes Mar 15, 2022
View reviewed changes
Copy link
Contributor

@terhorstd terhorstd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! 👍

@terhorstd terhorstd merged commit ec2b6c4 into nest:master Mar 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jougs jougs jougs approved these changes

@terhorstd terhorstd terhorstd approved these changes

Assignees
No one assigned
Labels
I: No breaking change Previously written code will work as before, no one should note anything changing (aside the fix) S: Normal Handle this with default priority T: Maintenance Work to keep up the quality of the code and documentation.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unbound variable error while running testsuite
3 participants
@clinssen @jougs @terhorstd