Return empty dictionary if get() is called on empty SynapseCollection
#2332
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stinebuu
added
S: Normal
hakonsbm
suggested changes
Mar 8, 2022
Co-authored-by: Håkon Bakke Mørk <hakon.mork@nmbu.no>
med-ayssar
approved these changes
Mar 16, 2022
|
|
||
| nrns = nest.Create('iaf_psc_alpha', 2) | ||
| nest.Connect(nrns, nrns, 'one_to_one') | ||
| conns = nest.GetConnections() | ||
| self.assertEqual(len(conns), 2) | ||
|
|
||
| nest.ResetKernel() | ||
| self.assertEqual(conns.get(), ()) | ||
| self.assertEqual(conns.get(), {}) | ||
| conns.set(weight=10.) |
There was a problem hiding this comment.
Is not resetting the kernel equivalent to adding or deleting connections, and in that case we should get a warning from the ConnectionManager stating a similar info as the following: ConnectionManager [Warning]: New connections created, connection descriptors previously obtained using 'GetConnections' are now invalid. In that case, the user should know that setting the weight in conn object won't be a valid operation, or maybe throw an error that the weight isn't in the connection dictionary anymore.
There was a problem hiding this comment.
@med-ayssar Could you make an issue for that?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #2318.