Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix static code check in CI #2343

Merged
merged 3 commits into from
Mar 15, 2022
Merged

Fix static code check in CI #2343

merged 3 commits into from
Mar 15, 2022

Conversation

clinssen
Copy link
Contributor

@clinssen clinssen commented Mar 14, 2022 •
edited

It seems that there are some problems with our CI, as there was a green checkmark on #2335 even though there was code syntax in there that violates the C++ clang-format check.

This PR fixes the syntax according to our clang-format coding standards.

The current CI pipeline is still broken (finding changed files fails); is there already an issue for that? I believe that there might be a PR coming in soon that anyway completely overhauls the CI pipeline. @terhorstd

jougs
jougs approved these changes Mar 15, 2022
View reviewed changes
Copy link
Contributor

@jougs jougs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this. I'm merging this immediately.

The solution for all CI problems is developed in terhorstd:separated-checks.

@jougs jougs merged commit 1d19b01 into nest:master Mar 15, 2022
@clinssen
Copy link
Contributor Author

Cheers! Potentially, we should hold off on merging any further PRs until the CI is fixed.

@terhorstd terhorstd added S: High Should be handled next T: Maintenance Work to keep up the quality of the code and documentation. I: No breaking change Previously written code will work as before, no one should note anything changing (aside the fix) labels Mar 18, 2022
@terhorstd terhorstd added this to To do in Build system and CI via automation Mar 18, 2022
@terhorstd terhorstd moved this from To do to Done in Build system and CI Mar 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jougs jougs jougs approved these changes

Assignees
No one assigned
Labels
I: No breaking change Previously written code will work as before, no one should note anything changing (aside the fix) S: High Should be handled next T: Maintenance Work to keep up the quality of the code and documentation.
Projects
Build system and CI
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@clinssen @jougs @terhorstd