Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correct doc for with-python CMake option and remove Python 2 check. #2345

Merged
merged 2 commits into from
Mar 18, 2022
Merged

Correct doc for with-python CMake option and remove Python 2 check. #2345

merged 2 commits into from
Mar 18, 2022

Conversation

heplesser
Copy link
Contributor

  • For some time, only ON and OFF have been valid values for -Dwith-python. This PR fixes the documentation on this point.
  • The PR also removes a check for -Dwith-python=2 which is not longer relevant.

@heplesser heplesser added S: Normal Handle this with default priority T: Maintenance Work to keep up the quality of the code and documentation. I: No breaking change Previously written code will work as before, no one should note anything changing (aside the fix) labels Mar 17, 2022
@heplesser heplesser added this to To do in Installation via automation Mar 17, 2022
jessica-mitchell
jessica-mitchell approved these changes Mar 18, 2022
View reviewed changes
Copy link
Contributor

@jessica-mitchell jessica-mitchell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good from my end!

Installation automation moved this from To do to Review Mar 18, 2022
@stinebuu
Copy link
Contributor

Looks good! But could you also update the docstring in CMakeLists.txt?

nest-simulator/CMakeLists.txt

Lines 47 to 48 in 277114f

# use Python to build PyNEST
set( with-python ON CACHE STRING "Build PyNEST [default=ON]. To set a specific Python, give the install path." )

@heplesser
Copy link
Contributor Author

Looks good! But could you also update the docstring in CMakeLists.txt?

nest-simulator/CMakeLists.txt

Lines 47 to 48 in 277114f

# use Python to build PyNEST
set( with-python ON CACHE STRING "Build PyNEST [default=ON]. To set a specific Python, give the install path." )

Done.

@stinebuu stinebuu merged commit 0c07d16 into nest:master Mar 18, 2022
Installation automation moved this from Review to Done Mar 18, 2022
@heplesser heplesser deleted the fix-outdated-cmake-python-switch-and-doc branch April 20, 2022 11:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jessica-mitchell jessica-mitchell jessica-mitchell approved these changes

@stinebuu stinebuu stinebuu approved these changes

Assignees
No one assigned
Labels
I: No breaking change Previously written code will work as before, no one should note anything changing (aside the fix) S: Normal Handle this with default priority T: Maintenance Work to keep up the quality of the code and documentation.
Projects
Installation
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@heplesser @stinebuu @jessica-mitchell